Refactoring: Function onMouseDown Issues: 29#45
Refactoring: Function onMouseDown Issues: 29#45izhanlara wants to merge 2 commits into2listic:mainfrom
Conversation
| function handleRightClick(event) { | ||
| const hitResult = paper.project.hitTest(event.point, drawingConfig.hitTest); | ||
|
|
||
| if (hitResult?.item.className === 'Path') { |
There was a problem hiding this comment.
Please check also if the path is not part of the grid or if we hit a point (those cases would rise an error).
The code below is working fine for me:
if (
hitResult?.type === 'stroke' &&
hitResult?.item.className === 'Path' &&
hitResult.item.parent?.name !== 'grid'
)There was a problem hiding this comment.
Hi @pcolt,
This code it's working. You like to change and add your if?
`function handleRightClick(event) {
const hitResult = paper.project.hitTest(event.point, drawingConfig.hitTest);
if (hitResult?.item.className === 'Path') {
selectedLine = hitResult.item;
createContextMenu(event.event);
return true; // The right-click found a target and was handled
}
return false;
}`
`function handleRightClick(event) {
const hitResult = paper.project.hitTest(event.point, drawingConfig.hitTest);
if (
hitResult?.type === 'stroke' &&
hitResult?.item.className === 'Path' &&
hitResult.item.parent?.name !== 'grid'
) {
selectedLine = hitResult.item;
createContextMenu(event.event);
return true;
}
return false;
}`
It's the same result. You say.
There was a problem hiding this comment.
Try to right click on a red point or on the empty grid and then click Delete and you should see an error in the console tab
Screencast from 2025-10-08 09-05-36.webm
| paper.view.onMouseDown = function (event) { | ||
| // Handle right-clicks (Guard Clause) | ||
| if (event.event.button === 2) { | ||
| if (handleRightClick(event)) { |
There was a problem hiding this comment.
Why are you checking here if the function returns true or false? I would just call the handleRightClick() function here and let the function handle all the cases without any unneeded complexity. If the event is a right click I would always stop here, or I am missing something? (I currently do know better the 3D part of this application)
| createContextMenu(event.event); | ||
| return true; // The right-click found a target and was handled | ||
| } | ||
| return false; // Nothing was done |
There was a problem hiding this comment.
Check the comment on line 261 and remove those returns if not needed
|
@pcolt Changes on me local code: Awaing to reply on me comment of: if (
hitResult?.type === 'stroke' &&
hitResult?.item.className === 'Path' &&
hitResult.item.parent?.name !== 'grid'
)After this I push |
|
@izhanlaraagarcia please see my new comment #45 (comment) |
|
@izhanlaraagarcia also remove your changes to file package-lock.json |
|
@pcolt done |
|
Thank you, you fixed the package-lock.json but the other comments are still to be addressed |
2 participants
Hi everyone,
#29
We have extracted the properties so that they are not repeated since they were repeated several times, in this way we have it centralized and it allows modifications in the future.
We create the right click function:
All code:
