fix(plugins): deduplicate plugins to keep only highest version#155
Open
CorentinLumineau wants to merge 1 commit into21st-dev:mainfrom
Open
fix(plugins): deduplicate plugins to keep only highest version#155CorentinLumineau wants to merge 1 commit into21st-dev:mainfrom
CorentinLumineau wants to merge 1 commit into21st-dev:mainfrom
Conversation
When multiple versions of the same plugin are installed, commands were displayed multiple times (e.g., /x:ask appearing 4 times for 4 versions of ccsetup). This fix adds deduplication logic in discoverInstalledPlugins() that: - Groups plugins by marketplace:name composite key - Compares versions using semver - Keeps only the highest version of each plugin Added: - safeParseVersion() helper for robust version parsing - deduplicatePluginsByVersion() function - semver dependency for version comparison Fixes duplicate plugin detection issue. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When multiple versions of the same plugin are installed (e.g., my-plugin v1.0.0, v2.0.0, v3.0.0, v4.0.0), commands were displayed multiple times (e.g.,
/my-commandappearing 4 times).This PR adds deduplication logic in
discoverInstalledPlugins()that:marketplace:namecomposite keyChanges
safeParseVersion()helper for robust version parsing (handlesv1.2,1.2, invalid versions)deduplicatePluginsByVersion()functionsemverdependency for reliable version comparisondiscoverInstalledPlugins()to deduplicate before returning/cachingEdge Cases Handled
undefined/nullversion"0.0.0"v1.2)"1.2.0"latest)"0.0.0"+ warning1.0.0-alpha)1.0.0)Test plan