Local primordial non-Gaussianities in initial conditions#631
Draft
jordanflitter wants to merge 1 commit intorelease-v4.2from
Draft
Local primordial non-Gaussianities in initial conditions#631jordanflitter wants to merge 1 commit intorelease-v4.2from
jordanflitter wants to merge 1 commit intorelease-v4.2from
Conversation
…nctions (not CLASS)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v4.2 #631 +/- ##
================================================
+ Coverage 88.01% 88.23% +0.22%
================================================
Files 32 32
Lines 4755 4760 +5
Branches 803 804 +1
================================================
+ Hits 4185 4200 +15
+ Misses 410 399 -11
- Partials 160 161 +1 ☔ View full report in Codecov by Sentry. |
Member
|
This looks cool @jordanflitter! I will refrain from a full review since it's in draft state, but I will note that I think Otherwise, I agree in spirit with all your notes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the ability to have local PNGs in the initial conditions. At this moment, it only works with
POWER_SPECTRUM!=CLASS, which is why it's in a draft state. The CLASS transfer function, being defined differently than the other transfer functions, requires a different implementation, so this PR will be in a draft state until there's also a support with havingPOWER_SPECTRUM=CLASSandPRIMORDIAL_NON_GAUSSIANITIES=True.Some notes:
hires_Phi, just to be able to see directly how the primordial gravitational field is modified due to PNGs. It is only allocated whenPRIMORDIAL_NON_GAUSSIANITIES=True, and it's a single (high-resolution) box in the initial conditions (unlike output boxes that we make at each node_redshift), so I'm not sure if users should be concerned about this extra memory allocation.InitialConditions.clikeadd_pngs_to_delta_box,add_pngs_to_Phi_box,multiply_by_factor_in_Fourier_spaceandPoisson_factor. I am not entirely sure that the last two functions should indeed be placed inInitialConditions.c. There is a lot of resemblance betweenfilter_boxandmultiply_by_factor_in_Fourier_space, and I actually think that we could use the latter to perform the former (since filtering is actually multiplying the box in Fourier space by a k-dependent factor, this is exactly whatmultiply_by_factor_in_Fourier_spacedoes). I am not sure this PR is the best place to do this, but I do think it worths of making an issue.