Skip to content

Add MCP integration and Developer Environments skill (v1.2.0)#6

Open
scottisloud wants to merge 10 commits into
mainfrom
scoot/feature/add-mcp-integration
Open

Add MCP integration and Developer Environments skill (v1.2.0)#6
scottisloud wants to merge 10 commits into
mainfrom
scoot/feature/add-mcp-integration

Conversation

@scottisloud

@scottisloud scottisloud commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Unify hooks and MCP in the existing 1password Cursor plugin at v1.2.0
  • Add mcp.json pointing at the local 1password-mcp binary
  • Add skills/1password-environments/SKILL.md for agent MCP workflows
  • Update README for combined hooks + MCP setup; add assets and .gitignore

Test plan

  • Install plugin via /add-plugin 1password or local copy
  • Confirm beforeShellExecution hook appears in Settings → Hooks
  • Run agent shell command (echo hello); verify allow/deny in Execution Log
  • Enable 1Password Labs MCP Server; confirm MCP connects in Cursor
  • List environments and variables via MCP tools

@scottisloud scottisloud marked this pull request as ready for review June 29, 2026 18:54
@scottisloud scottisloud requested a review from rishiy15 June 29, 2026 19:00
@scottisloud scottisloud requested review from JillRegan and bertrmz July 6, 2026 21:17
@scottisloud

scottisloud commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Adjusted scope slightly for expected agent behaviours to account for differences in how Cursor Agents work compared to some other agent clients.

Ready for review. Testing is a bit fiddly...

@scottisloud scottisloud force-pushed the scoot/feature/add-mcp-integration branch from 3a7a6e0 to 87be6b7 Compare July 9, 2026 22:27
Wire the 1Password desktop MCP server into the Cursor plugin manifest, add branding assets, document installation and usage in the README, and ship the 1password-environments agent skill with reference material for import-and-mount workflows.
Block direct .env and MCP doc reads that bypass the skill, nudge agents toward MCP-based imports, and require reading the skill before 1Password MCP tool calls.
@scottisloud scottisloud force-pushed the scoot/feature/add-mcp-integration branch from 87be6b7 to 081607a Compare July 9, 2026 22:31

@JillRegan JillRegan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected! Left some comments.

Another thing I want to mention is the .cmd wrapper on Windows (you'll notice we have this for validate-mounted-env-files which was implemented here). Essentially cursor tries to run the bash hook commands, and without .cmd file it can attempt the bash script and fail badly which opens the file in the editor. The .cmd stub just returns allow since mounts aren’t supported on Windows anyway.

So if on Windows and the plugin is installed and these new hooks execute it will be an unpleasant user experience because the bash scripts will fail and open in the editor. While I don't think we should address in this PR I do think we should work on a quick follow up. But we may need more discussion with the Cursor team to see how other folks are handling this, as a .cmd file for every hook is not ideal.

Comment thread mcp.json Outdated
Comment thread scripts/nudge-1password-import Outdated
Comment thread README.md
Comment thread scripts/deny-1password-docs-read Outdated
Comment thread rules/1password-environments.mdc Outdated
@scottisloud

Copy link
Copy Markdown
Contributor Author

Confirmed, Cursor seems to not have recognized it was failing to correctly load the plugin while I was developing it. As as a result, it implemented a TON of additional scaffolding that isn't required.

I'll make local changes to the marketplace-installed version of the plugin (which Cursor abides by) so I can accurately assess what's required for the desired behaviour, pull out what isn't, and port that over here.

scottisloud and others added 8 commits July 10, 2026 08:28
Remove MCP skill-read gates, doc-deny hooks, import nudges, and the agent rule. Update SKILL.md, reference.md, and README to document only what the plugin ships.

Co-authored-by: Cursor <cursoragent@cursor.com>
Bring over duplicate environment name handling in the skill, richer plugin manifest description, and simplified hooks.json from mcp-plugin-test-marketplace.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants