Changed TOTP to OTP to match documentation#88
Open
andrewcfitz wants to merge 3 commits into1Password:mainfrom
Open
Changed TOTP to OTP to match documentation#88andrewcfitz wants to merge 3 commits into1Password:mainfrom
andrewcfitz wants to merge 3 commits into1Password:mainfrom
Conversation
edif2008
approved these changes
Nov 11, 2024
Member
edif2008
left a comment
edif2008
left a comment
There was a problem hiding this comment.
Thank you for catching this and improving the Connect API spec! Truly appreciate it @andrewcfitz! 😄
Contributor
|
@andrewcfitz commits must be signed in order to merge this. Would you have a chance to sign them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a bug in the OpenAPI spec, where the field type for OTP was listed as TOTP.
https://developer.1password.com/docs/connect/connect-api-reference/#item-field-object