This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Closed
Conversation
Draft
Contributor
|
Replaced by #1887 – Truss folks have been closing out their old PRs and I'd like to keep this prominent for a little longer. |
Contributor
|
Cool, thanks
…________________________________
From: Ryan Hofschneider <notifications@github.com>
Sent: Tuesday, December 17, 2019 10:38:40 PM
To: 18F/culper <culper@noreply.github.com>
Cc: leonged <eleong@actionet.com>; Review requested <review_requested@noreply.github.com>
Subject: Re: [18F/culper] [WIP] [EN-3887] UI Refactor Demo (#1863)
EXTERNAL EMAIL
Replaced by #1887<#1887> – Truss folks have been closing out their old PRs and I'd like to keep this prominent for a little longer.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#1863?email_source=notifications&email_token=ANAGXTI3O6MNNKYIJ2ZATN3QZGLMBA5CNFSM4IXS6KKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEX34A#issuecomment-566853104>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANAGXTK6QU3DYYWYL4QGECTQZGLMBANCNFSM4IXS6KKA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch is a proof of concept of how to go about building new form input components, and hook them up to the section errors that come from Redux. It is for demo purposes and should not be merged as-is.
Fieldcomponent).NameFieldsetcomponent (demo'd side by side the existing Name component on the Applicant Name section).Checklist for Reviewer
More details about this can be found in docs/review.md