Skip to content

Pass through bodyParser.json() middleware options#1102

Merged
gboone merged 1 commit intostagingfrom
json-options
Aug 17, 2015
Merged

Pass through bodyParser.json() middleware options#1102
gboone merged 1 commit intostagingfrom
json-options

Conversation

@mbland
Copy link
Copy Markdown
Contributor

@mbland mbland commented Aug 17, 2015

The public Hub push in 18F/hub#370 failed due to the webhook exceeding the default 100K limit, just as in 18F/pages#15. This applies the same fix as 18F/pages. Still waiting on coreh/hookshot#12 to get merged upstream, so before this change is deployed, I'll need to install 18F/hookshot#json-options on the server:

npm install git+ssh://git@github.com/18F/hookshot.git#json-options

cc: @gboone

gboone added a commit that referenced this pull request Aug 17, 2015
Pass through bodyParser.json() middleware options
@gboone gboone merged commit bfbfe9f into staging Aug 17, 2015
@gboone gboone deleted the json-options branch August 17, 2015 18:56
mbland pushed a commit to 18F/hub that referenced this pull request Aug 17, 2015
The public Hub push in #370 failed due to the webhook exceeding the
default 100K limit, just as in 18F/pages#15. This applies the same fix as
18F/pages. Still waiting on coreh/hookshot#12 to get merged upstream, so
I've already installed 18F/hookshot#json-options on the server:

```
npm install git+ssh://git@github.com/18F/hookshot.git#json-options
```

Note: I applied this in 18F/18f.gsa.gov#1102, but really should've just
applied it here. No harm done, however.
@gboone gboone mentioned this pull request Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants