Fix large images still not being openable#59
Open
Filoppi wants to merge 1 commit into13thsymphony:release-1.1.0from
Open
Fix large images still not being openable#59Filoppi wants to merge 1 commit into13thsymphony:release-1.1.0from
Filoppi wants to merge 1 commit into13thsymphony:release-1.1.0from
Conversation
5120x1440 jxr HDR images fail to be opened when the app is in a maxed out window, because the histogram still fails to draw (EndDraw() has an exception within itself, and returns error D1225). I haven't really spent time analyzing what the histogram is used for, but I have found that the jxr image is visualized exactly the same way whether the EndDraw() failed or not (thus the max luminance remains n/a). I can manage to open these images, but only if the app started in a small window. If it's maxed out, it will throw the error. I'm on the latest version of Win 11 and have a recent high end Nvidia card (I don't think it matters). My resolution is set to 5120x1440 and DPI to 100% (so 96). I have found that changing the "SetDpi()" call from 96 to 1 avoids the exception to be throw, though it actually kind of breaks the final image rendering. I know that makes no sense, I was just messing around. Before the code was changed to add the "SetDpi()" workaround, it errored out even more often, though I'm not sure exactly what improved.
Author
|
This fork has some of the some fixes for the stuff I mentioned above: |
Author
|
@13thsymphony hey, sorry to bother, just wondering if there was any intention of merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5120x1440 jxr HDR images fail to be opened when the app is in a maxed out window, because the histogram still fails to draw (
EndDraw()has an exception within itself, and returns errorD1225). I haven't really spent much time analyzing how the histogram is used, but I have found that the jxr image is visualized exactly the same way whether theEndDraw()failed or not (thus the max luminance (CLL) remains n/a). I can manage to open these images, but only if the app started in a small window. If it's maxed out, it will throw the error.I'm on the latest version of Win 11 and have a recent high end Nvidia card (I don't think it matters). My resolution is set to 5120x1440 and DPI to 100% (so 96).
I have found that changing the
SetDpi()call from 96 to 1 avoids the exception to be throw, though it actually kind of breaks the final image rendering and the max luminance value. I know that makes no sense, I was just messing around.Before the code was changed to add the
SetDpi()workaround (from @imbushuo), it errored out even more often, though I'm not sure exactly what improved.This is unrelated to this PR, but I also noticed the max luminance calculated by the app depends on the window size. You can test it by making the window tiny and opening the same image multiple times.
I suppose the histogram is rendered in a way that depends on the window size, while it shouldn't?