Merge Request: Colony System Improvements, Resource Labeling, Bug Fixes & Code Cleanup #105

TariqTheCoder · 2025-11-16T06:54:53Z

Summary

This merge request introduces several gameplay improvements, UI enhancements, bug fixes, text corrections, and code clean-ups across the Colony Management, Resources, Parts modules, and UI.
It also removes cleans grammar/log messages for consistency.

Key Features & Changes

1. Colony Interaction Improvements

Dynamic "Create/View Colony" Button

Button now automatically switches between:

"Create Colony" when the player is not in any colony
"View Colony Information" when near an existing colony

Button callback switches appropriately (CreateColony vs OpenColony).

Corrected Colony Creation Message

Replaced “Too close to another colony” with “Already inside another colony” to be more accurate.

2. Resource System Enhancements

Resource Deposits Now Display Size Labels on the Map
Deposits show Small / Medium / Large / Huge instead of a generic label.

Fixed Typo in Class Name

ReourceDeposit → ResourceDeposit

3. Parts Module Fixes & Improved Messaging

ExcavatorModule
-> Fixed grammar in messages
-> Improved error clarity (e.g., “Material container needed for storage”)
BalloonModule

-> More accurate vacuum message - (“Cannot deploy in a vacuum”)
ScannerModule

-> Better atmosphere-use message

-> Corrected altitude variable typo

-> Improved log output when deposits are found
HingeModule

-> Cleaned redundant comments

-> Improved loop-detection clarity

4. Code Quality & Cleanup

Replaced incorrect/typo-filled log strings
Ensures consistent language across the mod.

Conclusion

Colony creation and viewing button behaviour
Map now displays deposit size
Balloon and excavator behave correctly with new messages
Scanner altitude and atmosphere logic verified
Log messages and lists work better

Note:
This MR is safe to merge and focuses on clarity, bug-fixing, and usability.
No gameplay rebalance is included—only improvements.

…h insufficient resources or buildings. Fixed spelling and grammatical errors. Changes size and padding of Colonies button, and changed the text to 'Launch From Colony'. Removed redundant Information text subheading in the colony overview and instead added name.

…or create a colony when appropriate distance away from the colony

…t of deposits to 4-8 and tweaked other values for cleaner generation

TariqTheCoder · 2025-11-16T06:55:11Z

@dani0105

dani0105 · 2025-11-19T02:40:55Z

I'll review and test the changes this week

dani0105

I see you didn't compile the project, because there are errors that will prevent a valid build. Fix all the comments and show me screenshots of the changes.

dani0105 · 2025-11-23T02:47:10Z

MoreParts/World/PlanetResourceData.cs

            for (short index = 0; index < 9; index++)
            {
-                int amount = rnd.Next(1000,3000);
+                int amount = rnd.Next(0,4000);


The idea is that there are always resources in the deposits.

dani0105 · 2025-11-23T02:47:39Z

MoreParts/World/PlanetResourceData.cs

             * <returns> True if there are more resources</returns>
             */
-            public bool takeRsources(double quantity)
+            public bool takeResources(double quantity)


update all the references for this method

dani0105 · 2025-11-23T02:49:53Z

MoreParts/UI/BuildingColonyGUI.cs

+        private static void ShowMenu(string text, string option)
+        {
+            SizeSyncerBuilder.Carrier sizeSync;
+            ButtonBuilder[] array = new ButtonBuilder[1];
+            new SizeSyncerBuilder(out sizeSync).HorizontalMode(SizeMode.MaxChildSize);
+            array[0] = ButtonBuilder.CreateButton(sizeSync, () => option, null, CloseMode.Stack);
+            MenuGenerator.ShowChoices(() => text, array);
        }


from where are you importing SizeSyncerBuilder, ButtonBuilder and MenuGenerator?

dani0105 · 2025-11-23T02:52:02Z

MoreParts/Patches/BuildManagerPatcher.cs

            Builder.AttachToCanvas(holder, Builder.SceneToAttach.CurrentScene);

-            SFS.UI.ModGUI.Button button = Builder.CreateButton(ui.transform, 120, 40, -90,-95, () => ScreenManager.main.OpenScreen(() => _ui), "Colonies");
+            SFS.UI.ModGUI.Button button = Builder.CreateButton(ui.transform, 120, 40, -90,-95, () => ScreenManager.main.OpenScreen(() => _ui), "Launch From Colony");


"Select launch site" is probably more appropriate.

dani0105 · 2025-11-23T02:53:37Z

MoreParts/Parts/HingeModule.cs

This part is disabled. It is no longer used due to all the complications.

dani0105 · 2025-11-23T02:54:17Z

MoreParts/Parts/ExcavatorModule.cs

                return;
            }
            double countToExtract = _extractionCount * WorldTime.main.timewarpSpeed;
            bool thereAreMore = deposit.takeRsources(countToExtract);


This still uses takeRsources

dani0105 · 2025-11-23T02:55:45Z

MoreParts/MorePartsMod.csproj

This change is not necessary

dani0105 · 2025-11-23T02:56:55Z

MoreParts/Managers/ResourcesManager.cs

        public Planet CurrentPlanet { set; get; }

-        public ReourceDeposit CurrentDeposit { private set; get; }
+        public ResourceDeposit CurrentDeposit { private set; get; }


you are only changing the name here, but not the class itself.

dani0105 · 2025-11-23T02:59:12Z

MoreParts/Managers/ColonyManager.cs

+            if (nearest != null)
+            {
+                // Change button to VIEW MODE
+                _createColonyButton.SetText("View Colony Information");


SetText does not exist

…3000

dani0105 · 2025-12-31T22:22:08Z

I see you didn't compile the project, because there are errors that will prevent a valid build. Fix all the comments and show me screenshots of the changes.

When I say screenshots of the changes, I mean the changes running in the game. I should have been clearer about that

TariqTheCoder · 2026-01-02T00:42:42Z

Hi @dani0105 I am having trouble compiling the mod and running it in game. How can I do this?

dani0105 · 2026-01-06T14:11:52Z

Place all DLLs from the "Managed" folder into the "Dependencies" folder. Compile the mod using Visual Studio Community. Once compiled, the mod's DLL will be located at /bin/debug/MorePartsMod.dll. Then, copy the DLL file to the "DLLs" folder on your Unity project and compile the mod.

TariqTheCoder added 8 commits November 16, 2025 16:13

Changed error message to pop-up box

df98eb5

Fixed multiple spelling mistakes and grammatical errors. Code clean up.

94a99c8

Clean up code and use more correct language in messages and logs

a037795

Create a button that allows you to view information when in a colony …

14959f0

…or create a colony when appropriate distance away from the colony

Feature: Label resource deposits based on size. Reduce range of amoun…

0c4c30d

…t of deposits to 4-8 and tweaked other values for cleaner generation

Finish Planet Resource fixes

8390f4a

Undoing changes to csproj

1843977

dani0105 requested changes Nov 23, 2025

View reviewed changes

Update range for amount of resources in a resource pocket to 1000 to …

77be0af

…3000

Final changes

3b93b44

Uh oh!

Merge Request: Colony System Improvements, Resource Labeling, Bug Fixes & Code Cleanup #105

Are you sure you want to change the base?

Merge Request: Colony System Improvements, Resource Labeling, Bug Fixes & Code Cleanup #105

Uh oh!

Conversation

TariqTheCoder commented Nov 16, 2025

Summary

Key Features & Changes

1. Colony Interaction Improvements

Dynamic "Create/View Colony" Button

Corrected Colony Creation Message

2. Resource System Enhancements

Fixed Typo in Class Name

3. Parts Module Fixes & Improved Messaging

4. Code Quality & Cleanup

Conclusion

Uh oh!

TariqTheCoder commented Nov 16, 2025

Uh oh!

dani0105 commented Nov 19, 2025

Uh oh!

dani0105 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dani0105 commented Dec 31, 2025

Uh oh!

TariqTheCoder commented Jan 2, 2026

Uh oh!

dani0105 commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone