TailwindFormatter as a Phoenix.LiveView attribute formatter#77
Open
aptinio wants to merge 1 commit into100phlecs:masterfrom
Open
TailwindFormatter as a Phoenix.LiveView attribute formatter#77aptinio wants to merge 1 commit into100phlecs:masterfrom
aptinio wants to merge 1 commit into100phlecs:masterfrom
Conversation
TailwindFormatter currently vendors Phoenix.LiveView.HTMLFormatter code so that it can use the private `tokenize/1` function. However, problems arise when the vendored code and the user's LiveView version gets out of sync. A PR has been submitted to the Phoenix.LiveView team in the hopes of having this function publicly exposed: phoenixframework/phoenix_live_view#3778 Instead, a suggestion was made to add an `:attribute_formatters` config option to Phoenix.LiveView.HTMLFormatter. This has been available since Phoenix.LiveView v1.1 phoenixframework/phoenix_live_view#3781 This PR removes the vendored code and converts TailwindFormatter from a mix formatter to an attribute formatter of Phoenix.LiveView.HTMLFormatter.
aptinio
force-pushed
the
phx-lv-attribute-formatter
branch
from
27ff2ee to
75b87c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TailwindFormatter currently vendors Phoenix.LiveView.HTMLFormatter code so that it can use the private
tokenize/1function. However, problems arise when the vendored code and the user's LiveView version gets out of sync. A PR has been submitted to the Phoenix.LiveView team in the hopes of having this function publicly exposed:phoenixframework/phoenix_live_view#3778
Instead, a suggestion was made to add an
:attribute_formattersconfig option to Phoenix.LiveView.HTMLFormatter. This has been available since Phoenix.LiveView v1.1phoenixframework/phoenix_live_view#3781
This PR removes the vendored code and converts TailwindFormatter from a mix formatter to an attribute formatter of
Phoenix.LiveView.HTMLFormatter.