Open
Conversation
Contributor
|
Looks cool. Modal button labels still need to be completed, as well as error messages in toasts and modal labels. I'd suggest merging after the client is approximately stable (soon) as adding translation can slow down iteration. |
blue-falcon-9001
force-pushed
the
feat/i18n
branch
from
6b60e07 to
d38a6d5
Compare
blue-falcon-9001
force-pushed
the
feat/i18n
branch
from
d38a6d5 to
395bde1
Compare
Author
|
ACK, narrowed scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.