Skip to content

fix: Robustify event listener cleanup#5

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/robust-event-cleanup
Open

fix: Robustify event listener cleanup#5
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/robust-event-cleanup

Conversation

@sentry
Copy link

@sentry sentry bot commented Mar 17, 2026

Fixes SPLITS-TEAMS-BH. The issue was that: Content script's detachProviderEvents attempts removeListener on this.provider which is null due to cleanup race condition.

  • Wrapped removeListener calls with a try...catch block.
  • Prevents errors during cleanup when the provider might be in an indeterminate state (e.g., during window unload).
  • Improves the robustness of event handler removal.

This fix was generated by Seer in Sentry, triggered by Greg Rolwes. 👁️ Run ID: 11915706

Not quite right? Click here to continue debugging with Seer.

@gregfromstl gregfromstl requested a review from r0ohafza March 17, 2026 19:54
@gregfromstl
Copy link

@r0ohafza apparently you have to give it feeback in sentry’s UI and it opens an entirely new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant