-
Notifications
You must be signed in to change notification settings - Fork 44
MegaEth #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MegaEth #453
Conversation
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
…plier (do it the right way)
e1Ru1o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something to add is a modification to ignore MegaEth contracts when checking contract size, quite hard that we hit the limit but might be easy to go over 24kb and make CI fail. Just skipping src/chains/MegaEth should do the work
we actually operate on a bunch of chains with abnormal contract size limits. Just off the top of my head, Arbitrum and Monad have increased limits. If it starts failing, I'll modify the action to exclude them, but at present the only chains where we're close to the limit are also chains where the limit is actually enforced :( |
https://docs.megaeth.com/megaevm