Skip to content

Conversation

@duncancmt
Copy link
Collaborator

@duncancmt duncancmt requested a review from e1Ru1o December 17, 2025 15:04
@duncancmt duncancmt self-assigned this Dec 17, 2025
@duncancmt duncancmt requested a review from dekz as a code owner December 17, 2025 15:04
@immunefi-magnus
Copy link

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

Copy link
Contributor

@e1Ru1o e1Ru1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something to add is a modification to ignore MegaEth contracts when checking contract size, quite hard that we hit the limit but might be easy to go over 24kb and make CI fail. Just skipping src/chains/MegaEth should do the work

@duncancmt
Copy link
Collaborator Author

ignore MegaEth contracts when checking contract size

we actually operate on a bunch of chains with abnormal contract size limits. Just off the top of my head, Arbitrum and Monad have increased limits. If it starts failing, I'll modify the action to exclude them, but at present the only chains where we're close to the limit are also chains where the limit is actually enforced :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants