[wip] Merkle Tree verification#10
Draft
LindaGuiga wants to merge 8 commits intomainfrom
Draft
Conversation
…on. Add test for Keccak.
4l0n50
reviewed
Aug 29, 2025
| // `DIGEST_ELEMS` is the number of digest elements of the hash. `MAX_TREE_HEIGHT` is the maximal tree height that can be handled by the AIR. | ||
| pub struct MerkleTreeAir<F, C, const DIGEST_ELEMS: usize, const MAX_TREE_HEIGHT: usize> | ||
| where | ||
| F: PrimeField64, |
There was a problem hiding this comment.
Why do you need PrimeField64 and not only PrimeField?
4l0n50
reviewed
Aug 29, 2025
| .assert_zero(local.length.clone() - next.length.clone()); | ||
|
|
||
| let mut cur_to_hash = vec![AB::Expr::ZERO; 2 * DIGEST_ELEMS]; | ||
| for i in 0..DIGEST_ELEMS { |
There was a problem hiding this comment.
Suggested change
| for i in 0..DIGEST_ELEMS { | |
| // Hash either (local.sibiling, local.state) or (local.state, local.sibling) depending on the current index bit | |
| for i in 0..DIGEST_ELEMS { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This verifies verify_batch for Merkle trees. There are quite a few interactions with the public inputs and the FRI table, which can't be implemented yet.