chore: drop legacy // +build comment#1931
Closed
findfluctuate wants to merge 1 commit into0xPolygon:developfrom
Closed
chore: drop legacy // +build comment#1931findfluctuate wants to merge 1 commit into0xPolygon:developfrom
findfluctuate wants to merge 1 commit into0xPolygon:developfrom
Conversation
Signed-off-by: findfluctuate <findfluctuate@outlook.com>
|
Contributor
Author
|
@kamuikatsurgi @pratikspatil024 Hi, Could you please review this PR at your convenience? Thank you very much. It seems that the CI failure is unrelated to this change Progress: 3445/6000 transactions mined (120 seconds elapsed)
Load test still running after timeout, terminating...
Waiting 10 seconds for final transactions to settle...
=== Final Verification ===
Test results:
Initial nonce: 1023
Final nonce: 6187
Total transactions mined: 5164 / 6000
❌ Combined load test with producer rotation FAILED
Only 5164 out of 6000 transactions were mined
Check /tmp/polycli_rotation_test.log for details
Cleaning up network latency... |
Member
Can you pull in the latest changes from develop? |
|
This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
18 tasks
|
This PR was closed because it has been stalled for 35 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From Go 1.17, the preferred syntax for build constraints is
//go:build,which replaces the old
// +buildform. The old style is now considereddeprecated but still supported for backward compatibility.
This change removes the obsolete
// +build xxxline, keeping only themodern
//go:build xxxdirective.More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines
Design Doc / Proposal：
https://go.dev/design/draft-gobuild
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it