chore(agglayer): address review nits from #2955#2957
Merged
Conversation
The conditional matches! arm in test_bridge_in_claim_to_p2id enumerates both ClaimDataSource variants (L1ToMiden | L2ToMiden) — the only two — so the branch is always taken and the Option<Account> wrapping forces a needless if let Some(...) around the post-mint consume+assert block. Construct destination_account unconditionally and flatten the consume block to match the pattern used by the other bridge_in tests.
mmagician
added
the
no changelog
mmagician
added
agglayer
flamiinngo
reviewed
May 20, 2026
flamiinngo
left a comment
flamiinngo
left a comment
There was a problem hiding this comment.
The docstring cleanup is the right call implementation docs shouldn't carry PR-narrative context that becomes misleading once merged. The test simplification in bridge_in.rs is correct; the matches! guard was redundant since L1ToMiden and L2ToMiden are the only two ClaimDataSource variants, so the check always evaluated to true.
Flattening to an unconditional construction makes the intent clearer.
partylikeits1983
approved these changes
May 20, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
Thank you for opening a PR to clean this up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2955
Commit 1 —
docs(agglayer): drop port-narrative phrases from faucet docstringsAddresses:
Commit 2 —
test(agglayer): always construct deterministic destination accountAddresses:
The conditional
matches!(data_source, ClaimDataSource::L1ToMiden | ClaimDataSource::L2ToMiden)was removed. Also, flattenedOption<Account>toAccount, and re-indented theif let Some(...)consume block to match the pattern in the file's other tests.🤖 Generated with Claude Code