feat: implement TransactionEventId::event_name and host name resolution#2628
Open
PhilippGackstatter wants to merge 3 commits intonextfrom
Open
feat: implement TransactionEventId::event_name and host name resolution#2628PhilippGackstatter wants to merge 3 commits intonextfrom
TransactionEventId::event_name and host name resolution#2628PhilippGackstatter wants to merge 3 commits intonextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
TransactionEventId::event_nameand host name resolution.build.rs.TransactionEventId::event_nameto map event ID to name.Host::resolve_eventfor all hosts to improve error messages.For example, an error in an event handler currently gives:
We now get the same error message, but with:
So the event name is contained in the error (though we already knew that from the constant name too).
There may be other benefits of implementing
Host::resolve_eventbut, I'm not sure.closes #2043