Note tag 32bit routing(#2309)#2329
Merged
PhilippGackstatter merged 16 commits into0xMiden:nextfrom Jan 29, 2026
Merged
Conversation
Comment on lines
+281
to
+288
| let len = 32; | ||
|
|
||
| let tag = NoteTag::with_custom_account_target(account_id, len)?; | ||
|
|
||
| let prefix = account_id.prefix().as_u64(); | ||
| let expected = (prefix >> (64 - len)) as u32; | ||
|
|
||
| assert_eq!(tag.as_u32(), expected, "full 32-bit tag should match account prefix"); |
Contributor
There was a problem hiding this comment.
Same here regarding using the previous test setup as it's harder to understand now. All we need here is a simple assertion:
assert_eq!(
(account_id.prefix().as_u64() >> 32) as u32,
tag.as_u32(),
"32 most significant bits should match"
);
Contributor
There was a problem hiding this comment.
I think this comment wasn't addressed.
…or tag length handling
Comment on lines
+281
to
+288
| let len = 32; | ||
|
|
||
| let tag = NoteTag::with_custom_account_target(account_id, len)?; | ||
|
|
||
| let prefix = account_id.prefix().as_u64(); | ||
| let expected = (prefix >> (64 - len)) as u32; | ||
|
|
||
| assert_eq!(tag.as_u32(), expected, "full 32-bit tag should match account prefix"); |
Contributor
There was a problem hiding this comment.
I think this comment wasn't addressed.
swaploard
force-pushed
the
note-tag-32bit-routing(#2309)
branch
from
9e70508 to
5c53c17
Compare
PhilippGackstatter
approved these changes
Jan 28, 2026
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
We usually try to avoid force pushing after review have started. The latest force push has rolled back a few suggestions I committed earlier. I have now pushed some other fixes, like for build_note_tag_for_network_account.
Let's wait for another review before merging this.
Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
bobbinth
approved these changes
Jan 28, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you. I left some comments inline - but we can probably address them in a follow-up.
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
* feat: update note tag length to support up to 32 bits for network accounts * chore: update changelog for note tag length support up to 32 bits * refactor: remove unused NoteTag references and update related logic for tag length handling * refactor: update note tag length to support up to 32 bits for network * refactor: simplify changelog entry for note tag length update * refactor: clarify note tag construction details for account targeting * refactor: update note tag length references to use MAX_ACCOUNT_TARGET_TAG_LENGTH * refactor: update assertion for account target tag to check 32 most significant bits * refactor: improve documentation for routing parameters attachment in Address * chore: small improvements * Apply suggestion from @PhilippGackstatter Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com> Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor NoteTag account targets to contain up to 32 bits (#2309)
This PR completes the refactor discussed after #2285 by allowing NoteTag account targets to use the full 32-bit space, while keeping RoutingParameters constrained to a representable format.