Add "in-flight" capability to SWAP note#1904
Draft
partylikeits1983 wants to merge 13 commits intonextfrom
Draft
Conversation
mmagician
reviewed
Sep 17, 2025
partylikeits1983
changed the title
partylikeits1983
added
the
standards
Contributor
Author
|
Converting this PR to draft mode as this is a low priority issue atm. |
mmagician
added
the
pr-from-maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how the current SWAP note implementation can be modified to allow for SWAP notes to be matched against each other by an account that does not contain any assets.
This PR contains a test,
settle_coninceidence_of_wants_in_flightwhich demonstrates how a "matching" account can settle a "coincidence of wants" (two identical counter party SWAP notes) without containing any of the respective SWAP note assets.