fix(mempool): inflight notes are considered unauthenticated once pruned#2097
Open
Mirko-von-Leipzig wants to merge 2 commits into
Open
fix(mempool): inflight notes are considered unauthenticated once pruned#2097Mirko-von-Leipzig wants to merge 2 commits into
Mirko-von-Leipzig wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic in the mempool which can occur when under extreme load.
The root cause is some missing book keeping around block pruning. What happens is that
Acreates noteA'Bconsumed noteA', this succeeds because the mempool knows the note is inflight.Ais committed in blockCCis eventually pruned, removing noteA'from all graphsBis then selected for inclusion in a batchpanic!becauseB's unauthenticated noteA'is now unknownThe fix is to mark all notes from pruned blocks as authenticated (since we know they definitely exist and are committed). The fix was tested and confirmed using TDD.
This only occurred under extreme load because it required enough transactions to delay selection of
Bto afterAwas both committed and pruned.Fixes #2079