fix: set RUSTUP_TOOLCHAIN=stable for MSRV check in publish workflow#1811
Closed
mmagician wants to merge 1 commit intorelease/v0.14.0-alphafrom
Closed
fix: set RUSTUP_TOOLCHAIN=stable for MSRV check in publish workflow#1811mmagician wants to merge 1 commit intorelease/v0.14.0-alphafrom
mmagician wants to merge 1 commit intorelease/v0.14.0-alphafrom
Conversation
The publish workflow's MSRV check fails because rust-toolchain.toml pins Rust to 1.91, which interferes with cargo-msrv's toolchain resolution. The nightly workflow already handles this correctly by setting RUSTUP_TOOLCHAIN=stable. Apply the same fix here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Mirko-von-Leipzig
approved these changes
Mar 19, 2026
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Ah thanks! I didn't know msrv was also present here.
Contributor
Author
|
hmm judging by the failed jobs here, this might not be needed: the issue was in that the newly added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-msrv.sh) fails for every workspace member becauserust-toolchain.tomlpins the channel to1.91, which interferes withcargo-msrv's toolchain resolutionRUSTUP_TOOLCHAIN: stable(with an explicit comment explaining why)Context
Failed run: https://github.com/0xMiden/node/actions/runs/23306258363/job/67781096134
The nightly workflow's MSRV checks all pass because it sets
env: RUSTUP_TOOLCHAIN: stable. The publish workflow was missing this override, causingcargo msrv verifyto fail whenrust-toolchain.tomlis present.Test plan
🤖 Generated with Claude Code