Skip to content

feat: add miden-verify to toolchain 0.14.0#199

Merged
bitwalker merged 1 commit into
0xMiden:mainfrom
walnuthq:feat/add-miden-verify
May 21, 2026
Merged

feat: add miden-verify to toolchain 0.14.0#199
bitwalker merged 1 commit into
0xMiden:mainfrom
walnuthq:feat/add-miden-verify

Conversation

@saimeunt
Copy link
Copy Markdown
Contributor

This PR adds Miden Verify a CLI responsible for verifying Miden accounts and notes to midenup as a verify component accessible through miden verify.

The miden-verify CLI is just a wrapper performing API calls to a "Verification API" configurable via --verifier-url.

The underlying API doing the actual verification is documented here: https://walnutlabs.notion.site/Public-Miden-Contract-Verification-API-3113cefbe64b807eaa92d3c673bde0bc

At the moment a PoC implementation of this API has been released as part of the Miden Playground and is leveraged by the MidenScan explorer to display Rust source codes of verified accounts and notes.

An ongoing work is in progress to extract this verification API out of the Miden Playground project and release it as a set of self-hostable services codenamed Miden Sourcify.

@lima-limon-inc This PR ends up being exactly the same as your initial suggestion #186 thanks again for your help on this!

Closes #185

Copy link
Copy Markdown
Collaborator

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Ideally, new executable components would specify prebuilt artifacts, which should be produced as part of the release workflow in that repo (see miden-debug for example). Currently, the protocol repo doesn't produce those artifacts (@lima-limon-inc will likely be opening a PR for that soon). In the meantime, we may make components like this that need to be built from source optional, to avoid making midenup initialization time any more painful than it currently is, until all components are providing prebuilt artifacts.

@lima-limon-inc is working on a change to support that, and to address some related issues, via toolchain profiles. I'll probably wait to merge this until those land, which I expect to be soon - that we can make this new component temporarily optional, until we have prebuilt artifacts available for it.

Comment thread manifest/channel-manifest.json Outdated
Comment thread manifest/channel-manifest.json Outdated
@saimeunt
Copy link
Copy Markdown
Contributor Author

@bitwalker Thanks for your comments, this is super helpful to understand the correct process of adding a new component to midenup.

I have addressed your suggested changes by removing the unnecessary aliases key and moving from github repo to crates.io regarding fetching source.
We are looking into generating pre-built artifacts as part of future releases to speed up installs as requested.
Until then, this can wait and ultimately merged after either optional components are supported or we provide artifacts.

@lima-limon-inc
Copy link
Copy Markdown
Collaborator

lima-limon-inc commented Apr 30, 2026

Currently, the protocol repo doesn't produce those artifacts (@lima-limon-inc will likely be opening a PR for that soon).

Speaking of which, I've added the ProtocolLib's artifact to their CI on this PR 0xMiden/protocol#2859

In the meantime, we may make components like this that need to be built from source optional, to avoid making midenup initialization time any more painful than it currently is, until all components are providing prebuilt artifacts.
(...)
@lima-limon-inc is working on a change to support that, and to address some related issues, via toolchain profiles. I'll probably wait to merge this until those land, which I expect to be soon - that we can make this new component temporarily optional, until we have prebuilt artifacts available for it.

FYI @saimeunt I'll be opening a PR soon implementing this profiles feature soon.

We are looking into generating pre-built artifacts as part of future releases to speed up installs as requested.
Until then, this can wait and ultimately merged after either optional components are supported or we provide artifacts.

If it helps here are a couple of PR where we've implemented artifact upload:

@saimeunt saimeunt force-pushed the feat/add-miden-verify branch from 1c408a9 to 99ace4c Compare May 12, 2026 12:51
@saimeunt
Copy link
Copy Markdown
Contributor Author

@lima-limon-inc Thank you for pointing out these PRs implementing the artifacts upload on each new release, this has been really helpful!

@bitwalker I believe I've addressed every problems you found out initially, can you please re-review this PR?

@saimeunt saimeunt requested a review from bitwalker May 12, 2026 13:13
Comment thread manifest/channel-manifest.json
@saimeunt saimeunt force-pushed the feat/add-miden-verify branch from 99ace4c to e5cba6e Compare May 21, 2026 13:54
@saimeunt saimeunt requested a review from bitwalker May 21, 2026 14:03
@bitwalker
Copy link
Copy Markdown
Collaborator

@saimeunt Can you sign your commit? I'd do it myself, but I can't push to your fork

@saimeunt saimeunt force-pushed the feat/add-miden-verify branch from e5cba6e to 68ed409 Compare May 21, 2026 14:36
@saimeunt
Copy link
Copy Markdown
Contributor Author

@bitwalker Thanks for the quick review, the commit is now verified.

@bitwalker bitwalker merged commit 257b245 into 0xMiden:main May 21, 2026
@saimeunt saimeunt deleted the feat/add-miden-verify branch May 21, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add miden-verify to midenup

3 participants