Implementation of system constraints#494
Closed
Al-Kindi-0 wants to merge 1 commit intoal-stack-constraintsfrom
Closed
Implementation of system constraints#494Al-Kindi-0 wants to merge 1 commit intoal-stack-constraintsfrom
Al-Kindi-0 wants to merge 1 commit intoal-stack-constraintsfrom
Conversation
plafer
reviewed
Oct 30, 2025
plafer
left a comment
plafer
left a comment
There was a problem hiding this comment.
Looks good!
The biggest change required as I see it is to remove the fmp and in_syscall columns and their associated constraints.
Al-Kindi-0
force-pushed
the
al-stack-constraints
branch
from
fcf4880 to
67d16a6
Compare
Al-Kindi-0
force-pushed
the
al-system-constraints
branch
from
3b16dbc to
7f866b1
Compare
Al-Kindi-0
added
the
no changelog
Al-Kindi-0
force-pushed
the
al-stack-constraints
branch
from
67d16a6 to
552be82
Compare
Al-Kindi-0
force-pushed
the
al-system-constraints
branch
from
7f866b1 to
942c2dd
Compare
Leo-Besancon
reviewed
Feb 2, 2026
| # | ||
| # Only three types of operations modify fn_hash: | ||
| # 1. CALL/DYNCALL: Load new hash (enter new procedure context) | ||
| # 2. SYSCALL: Preserve hash (enables kernel to authenticate caller) |
Collaborator
There was a problem hiding this comment.
nit: This does not seem to modify fn_hash contrary to what line 194 infers.
Leo-Besancon
approved these changes
Feb 2, 2026
Collaborator
Leo-Besancon
left a comment
Leo-Besancon
left a comment
There was a problem hiding this comment.
Left a nitpick, otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Would also benefit from the computed indices PR getting merged
Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md