Skip to content

fix: fix command line activation not working properly in some cases#870

Open
soumyamahunt wants to merge 9 commits into0x7c13:masterfrom
soumyamahunt:commandline
Open

fix: fix command line activation not working properly in some cases#870
soumyamahunt wants to merge 9 commits into0x7c13:masterfrom
soumyamahunt:commandline

Conversation

@soumyamahunt
Copy link
Copy Markdown
Contributor

  • Fixed command line activation not working for debug build of app.
  • Implemented unit tests for testing command line functionality.
  • Added checks in CI/CD pipeline for unit tests.

PR Type

What kind of change does this PR introduce?

  • Bugfix

  • CI/CD pipeline changes

@soumyamahunt
Copy link
Copy Markdown
Contributor Author

@Jasonstein trying to open files with debug mode in notepads in cmd was failing, I made changes to fix such issues and also added all the test cases I could think of for command line activation. Check them if you can think of some more could be added or some test cases contain invalid result comparison. I added checks in CI so that pipeline will fail if tests aren't passed.

Also, I added removableStorage permission to manifest, this permission would give Notepads access to external storage so that launching files from command line will be more successful. This permission is given silently without any prompt to user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant