Skip to content

feat: [Feature request] Auto insert new line at eof #1412 #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mokshano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: [Feature request] Auto insert new line at eof #1412 #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Notepads/Controls/TextEditor/TextEditor.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,11 +723,23 @@ private async Task<TextFile> SaveContentToFileAsync(StorageFile file)
var text = TextEditorCore.GetText();
var encoding = RequestedEncoding ?? LastSavedSnapshot.Encoding;
var lineEnding = RequestedLineEnding ?? LastSavedSnapshot.LineEnding;
text = EnsureEndsWithLineEnding(text);
await FileSystemUtility.WriteTextToFileAsync(file, LineEndingUtility.ApplyLineEnding(text, lineEnding), encoding); // Will throw if not succeeded
var newFileModifiedTime = await FileSystemUtility.GetDateModifiedAsync(file);
return new TextFile(text, encoding, lineEnding, newFileModifiedTime);
}

private string EnsureEndsWithLineEnding(string text)
{
if (string.IsNullOrEmpty(text)) return text;
if (!text.EndsWith("\n") && !text.EndsWith("\r"))
{
var effectiveLineEnding = RequestedLineEnding ?? LastSavedSnapshot.LineEnding;
return text + LineEndingUtility.GetLineEndingName(effectiveLineEnding);
}
return text;
}

public string GetContentForSharing()
{
return TextEditorCore.Document.Selection.StartPosition == TextEditorCore.Document.Selection.EndPosition ?
Expand Down