Remove quotes added by tailwindcss/typography in block quotes#230
Open
Remove quotes added by tailwindcss/typography in block quotes#230
Conversation
alametti
force-pushed
the
typography-quotes-and-word-break
branch
from
fda9f3e to
4839652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes automating opening and closing quotes in
<blockquote>elements.Problem
The typography plugin pulled into the frontend CSS adds
open-quotebefore the first<p>of a<blockquote>, and aclose-quoteafter the last one. This causes issues when the original feed already contains quotes (note""and"«/»"):This is also visually inconsistent because often
<blockquote>s will not contain a<p>at all (so no quote is currently added), or the last element may be something like a<ol>, in which case the quote would be added nonsensically before it.Solution
This PR configures
tailwindcss/typographyto not add these quotes.Here are the same screenshots as above after applying this patch:
Misc
This PR also specifies that go 1.26+ is now required in CONTRIBUTING.md