Added Blocks page and search by block functionality#100
Conversation
|
I see a few odd things in this PR, possibly from AI coding. E.g. it dropped trailing newline from some files randomly. I've seen Claude do this. You can ask it to add the missing trailing newlines and then add a rule to not generate broken files with no trailing newline to its set of rules for the repo. Also some places where there's a change marked in the diff but I can't see what actually changed. Possibly just need new glasses... |
infra/web-app/ingress.yaml
Outdated
| spec: | ||
| rules: | ||
| - host: dev.0l.fyi | ||
| - host: dev.scan.openlibra.world |
There was a problem hiding this comment.
Current canonical host name is: scan.openlibra.io. However, it isn't actually deployed from these files (see here: https://github.com/whichnode/libra-explorer-deployment) so whatever is in this file is moot anyway.
|
|
||
| public deeplinkProvider(data: { url: string }): string { | ||
| return `https://wallet.0l.fyi/explore?link=${data.url}`; | ||
| return `https://wallet.scan.openlibra.world/explore?link=${data.url}`; |
There was a problem hiding this comment.
This should probably be scan.openlibra.io
ol-fyi-local-infra/compose.yml
Outdated
| - ./volumes/postgres/var/lib/postgresql/data:/var/lib/postgresql/data | ||
| ports: | ||
| - 5432:5432 | ||
| - 5434:5432 |
There was a problem hiding this comment.
Couldn't immediately see what's behind this change. Was the port just wrong before?
There was a problem hiding this comment.
Local collision on the port mapping.
Is this docker compose being used in prod?
There was a problem hiding this comment.
It isn't but I wondered why it changed in this PR. Seemed to be no reason. Is it so it runs on your machine?
|
@dboreham |
3 participants
blocks.mp4