Fixed the recommended Qodana inspections

Author: mridang

spec/check_session_service_spec.py

@@ -20,6 +20,7 @@
 )
 
 
+# noinspection DuplicatedCode
 @pytest.fixture(scope="module")
 def base_url() -> str:
     """Provides the base URL for tests, skipping if unset."""

spec/check_user_service_spec.py

@@ -17,6 +17,7 @@
 )
 
 
+# noinspection DuplicatedCode
 @pytest.fixture(scope="module")
 def base_url() -> str:
     """Provides the base URL for tests, skipping if unset."""

spec/conftest.py

@@ -1,9 +1,12 @@
+# noinspection All
 # mypy: allow-untyped-defs
 from __future__ import annotations
 
 import os
 import platform
 import re
+
+# noinspection PyPep8Naming
 import xml.etree.ElementTree as ET
 from collections import defaultdict
 from collections.abc import Callable
@@ -101,24 +104,25 @@ def write_captured_output(self, report: TestReport) -> None:
             content_all = self._prepare_content(content_log, " Captured Log ")
         if self.xml.logging in ["system-out", "out-err", "all"]:
             content_all += self._prepare_content(content_out, " Captured Out ")
-            self._write_content(report, content_all, "system-out")
+            self._write_content(content_all, "system-out")
             content_all = ""
         if self.xml.logging in ["system-err", "out-err", "all"]:
             content_all += self._prepare_content(content_err, " Captured Err ")
-            self._write_content(report, content_all, "system-err")
+            self._write_content(content_all, "system-err")
             content_all = ""
         if content_all:
-            self._write_content(report, content_all, "system-out")
+            self._write_content(content_all, "system-out")
 
-    def _prepare_content(self, content: str, header: str) -> str:
+    @staticmethod
+    def _prepare_content(content: str, header: str) -> str:
         return "\n".join([header.center(80, "-"), content, ""])
 
-    def _write_content(self, report: TestReport, content: str, jheader: str) -> None:
+    def _write_content(self, content: str, jheader: str) -> None:
         tag = ET.Element(jheader)
         tag.text = bin_xml_escape(content)
         self.append(tag)
 
-    def append_pass(self, report: TestReport) -> None:
+    def append_pass(self) -> None:
         self.add_stats("passed")
 
     def append_failure(self, report: TestReport) -> None:
@@ -194,6 +198,7 @@ def append_skipped(self, report: TestReport) -> None:
             self.append(skipped)
             self.write_captured_output(report)
 
+    # noinspection PyAttributeOutsideInit
     def finalize(self) -> None:
         data = self.to_xml()
         # Preserve key attributes
@@ -244,6 +249,7 @@ def record_xml_attribute(request: FixtureRequest) -> Callable[[str, object], Non
     """
 
     # Declare noop
+    # noinspection PyUnusedLocal
     def add_attr_noop(name: str, value: object) -> None:
         pass
 
@@ -390,6 +396,7 @@ def _opentestcase(self, report: TestReport) -> _NodeReporter:
         reporter.record_testreport(report)
         return reporter
 
+    # noinspection DuplicatedCode
     def pytest_runtest_logreport(self, report: TestReport) -> None:
         """Handle a setup/call/teardown report, generating the appropriate
         XML tags as necessary.
@@ -413,11 +420,10 @@ def pytest_runtest_logreport(self, report: TestReport) -> None:
             -> teardown node2
             -> teardown node1
         """
-        close_report = None
         if report.passed:
             if report.when == "call":  # ignore setup/teardown
                 reporter = self._opentestcase(report)
-                reporter.append_pass(report)
+                reporter.append_pass()
         elif report.failed:
             if report.when == "teardown":
                 # The following vars are needed when xdist plugin is used.
@@ -518,6 +524,7 @@ def pytest_internalerror(self, excrepr: ExceptionRepr) -> None:
         # Record the exception as a standard JUnit <error> element
         reporter._add_simple("error", "internal error", str(excrepr))
 
+    # noinspection PyAttributeOutsideInit
     def pytest_sessionstart(self) -> None:
         """
         Called at the very start of the pytest session.

test/auth/test_client_credentials_authenticator.py

@@ -13,6 +13,7 @@ class ClientCredentialsAuthenticatorTest(OAuthAuthenticatorTest):
     Extends the base OAuthAuthenticatorTest class.
     """
 
+    # noinspection DuplicatedCode
     def test_refresh_token(self) -> None:
         time.sleep(20)
 

test/auth/test_web_token_authenticator.py

@@ -17,6 +17,7 @@ class WebTokenAuthenticatorTest(OAuthAuthenticatorTest):
     Test for WebTokenAuthenticator to verify JWT token refresh functionality using the builder.
     """
 
+    # noinspection DuplicatedCode
     def test_refresh_token_using_builder(self) -> None:
         time.sleep(20)
 

zitadel_client/api_client.py

@@ -17,6 +17,8 @@
 import zitadel_client.rest_response
 from zitadel_client import rest
 from zitadel_client.api_response import ApiResponse
+
+# noinspection PyPep8Naming
 from zitadel_client.api_response import T as ApiResponseT
 from zitadel_client.auth.no_auth_authenticator import NoAuthAuthenticator
 from zitadel_client.configuration import Configuration
@@ -85,6 +87,7 @@ def set_default_header(self, header_name: str, header_value: str) -> None:
 
     _default = None
 
+    # noinspection PyUnusedLocal
     @no_type_check
     def param_serialize(
         self,
@@ -102,6 +105,7 @@ def param_serialize(
         _request_auth=None,
     ) -> RequestSerialized:
         """Builds the HTTP request params needed by the request.
+        :param files:
         :param _host:
         :param auth_settings:
         :param method: Method to call.
@@ -319,6 +323,7 @@ def deserialize(self, response_text: str, response_type: str, content_type: Opti
         # fetch data from response object
         if content_type is None:
             try:
+                # noinspection PyUnusedLocal
                 data = json.loads(response_text)
             except ValueError:
                 data = response_text
@@ -331,13 +336,14 @@ def deserialize(self, response_text: str, response_type: str, content_type: Opti
                 data = ""
             else:
                 data = json.loads(response_text)
-        elif re.match(r"^text\/[a-z.+-]+\s*(;|$)", content_type, re.IGNORECASE):
+        elif re.match(r"^text/[a-z.+-]+\s*(;|$)", content_type, re.IGNORECASE):
             data = response_text
         else:
             raise ApiException(status=0, reason="Unsupported content type: {0}".format(content_type))
 
         return self.__deserialize(data, response_type)
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize(data, klass):  # noqa C901 too complex
@@ -355,7 +361,6 @@ def __deserialize(data, klass):  # noqa C901 too complex
             if klass.startswith("List["):
                 m = re.match(r"List\[(.*)]", klass)
                 assert m is not None, "Malformed List type definition"
-                sub_kls = m.group(1)
                 return [ApiClient.__deserialize(sub_data) for sub_data in data]
 
             if klass.startswith("Dict["):
@@ -385,6 +390,7 @@ def __deserialize(data, klass):  # noqa C901 too complex
         else:
             return ApiClient.__deserialize_model(data, klass)
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def parameters_to_tuples(params, collection_formats):
@@ -416,6 +422,7 @@ def parameters_to_tuples(params, collection_formats):
                 new_params.append((k, v))
         return new_params
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def parameters_to_url_query(params, collection_formats):  # noqa C901 too complex
@@ -502,6 +509,7 @@ def select_header_accept(accepts: List[str]) -> Optional[str]:
 
         return accepts[0]
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def select_header_content_type(content_types):
@@ -519,6 +527,7 @@ def select_header_content_type(content_types):
 
         return content_types[0]
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_file(response):
@@ -549,6 +558,7 @@ def __deserialize_file(response):
 
         return path
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_primitive(data, klass):
@@ -566,6 +576,7 @@ def __deserialize_primitive(data, klass):
         except TypeError:
             return data
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_object(value):
@@ -575,6 +586,7 @@ def __deserialize_object(value):
         """
         return value
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_date(string):
@@ -590,6 +602,7 @@ def __deserialize_date(string):
         except ValueError as err:
             raise rest.ApiException(status=0, reason="Failed to parse `{0}` as date object".format(string)) from err
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_datetime(string):
@@ -607,6 +620,7 @@ def __deserialize_datetime(string):
         except ValueError as err:
             raise rest.ApiException(status=0, reason=("Failed to parse `{0}` as datetime object".format(string))) from err
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_enum(data, klass):
@@ -621,6 +635,7 @@ def __deserialize_enum(data, klass):
         except ValueError as err:
             raise rest.ApiException(status=0, reason=("Failed to parse `{0}` as `{1}`".format(data, klass))) from err
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @staticmethod
     def __deserialize_model(data, klass: Any):
@@ -633,6 +648,7 @@ def __deserialize_model(data, klass: Any):
 
         return klass.from_dict(data)
 
+    # noinspection PyNestedDecorators
     @no_type_check
     @classmethod
     def get_default(cls):

zitadel_client/configuration.py

@@ -105,7 +105,6 @@ def logger_file(self) -> Optional[str]:
         If the logger_file is None, then add stream handler and remove file
         handler. Otherwise, add file handler and remove stream handler.
 
-        :param value: The logger_file path.
         :type: str
         """
         return self.__logger_file
@@ -133,7 +132,6 @@ def logger_file(self, value: Optional[str]) -> None:
     def debug(self) -> bool:
         """Debug status
 
-        :param value: The debug status, True or False.
         :type: bool
         """
         return self.__debug
@@ -166,7 +164,6 @@ def logger_format(self) -> str:
 
         The logger_formatter will be updated when sets logger_format.
 
-        :param value: The format string.
         :type: str
         """
         return self.__logger_format

zitadel_client/exceptions.py

@@ -119,6 +119,7 @@ def __init__(
             if self.reason is None:
                 self.reason = http_resp.reason
             if self.body is None and http_resp.data is not None:
+                # noinspection PyBroadException
                 try:
                     self.body = http_resp.data.decode("utf-8")
                 except Exception:  # noqa: S110