Checking the crate

[Its-Just-Nans]

I was checking the crate

1. it looks like we can get rid of generic-array - checked with cargo shear

2. Features combinations

   I was testing multiples features with

   cargo hack test --feature-powerset --all-targets
   # or better with
   cargo hack test --feature-powerset --all-targets --exclude-features _bzip2_any,_arbitrary,_deflate-any,_all-features

   And it seems that

   cargo test --all-targets --no-default-features

   Is failing (for the benchmarks) because i think we need to:

   • the std feature for getrandom devpendencies.
     or
   • change the errors of getrandom since without std it doesn't implement std::io::Error

3. Private features

   This command is failing

   cargo test --all-targets --no-default-features --features _bzip2_any

   this is normal since it's "private" but maybe we should remove the "private" featureS no ?

4. _all-features feature seems useless

[Its-Just-Nans]

@Pr0methean what about part 3 and 4 ?

[Pr0methean]

For number 3, what do you suggest we use instead, to gate code that's shared between all deflate implementations or all bzip2 implementations, including ones we may add in the future?

[Pr0methean]

We could use cfg_aliases, but it'd mean an extra dependency and a more convoluted build process.

[Its-Just-Nans]

For number 3, what do you suggest we use instead, to gate code that's shared between all deflate implementations or all bzip2 implementations, including ones we may add in the future?

Yeah I thought about maybe change the cfg(feature=_bzi2_any) to cfg(any(feature=bzip2, feature=bzip2-rs))

Same for others private

Another solution than using an external create cfg alizs would be to make our own zip-proc-macro crates, but this seems a little bit overkill for just an alias

Also it was also a question and reflexion, because maybe it's not a good idea to change the current state !

New point:

5. Looks like the unreserved feature looks also unused no?

[Pr0methean]

No, unreserved enables writing extra fields of types we don't recognize; see

zip2/src/write.rs

Lines 308 to 320 in 56ee7c2

	#[cfg(not(feature = "unreserved"))]
	{
	use crate::unstable::LittleEndianReadExt;
	let header_id = data.read_u16_le()?;
	if EXTRA_FIELD_MAPPING.contains(&header_id) {
	return Err(ZipError::Io(io::Error::other(
	format!(
	"Extra data header ID {header_id:#06} requires crate feature \"unreserved\"",
	),
	)));
	}
	data.seek(SeekFrom::Current(-2))?;
	}

.

[Pr0methean]

Closing because I don't think it's necessary or worth the trouble to replace _bzip2-any or _deflate_any with a fancier solution right now.