Skip to content

Conversation

@kakmonk
Copy link

@kakmonk kakmonk commented Dec 6, 2025

Updating the comment to signal its limitation to XTAL, not RTC, to avoid confusion.

Updating the comment to signal its limitation to XTAL not RTC.
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Hello @kakmonk, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added platform: ESP32 Espressif ESP32 area: I2C size: XS A PR changing only a single line of code labels Dec 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2025

#define I2C_TRANSFER_TIMEOUT_MSEC 500 /* Transfer timeout period */

/* Freq limitation when using different clock sources */
#define I2C_CLK_LIMIT_REF_TICK (1 * 1000 * 1000 / 20) /* REF_TICK, no more than REF_TICK/20*/
Copy link
Contributor

@sylvioalves sylvioalves Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kakmonk, I think all those defines (I2C_CLK_LIMI_xxx) are not being used at all and is probably leftovers from initial code. Perhaps you could update your PR to remove it all instead.

@sylvioalves
Copy link
Contributor

Closing this due to #100630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: I2C platform: ESP32 Espressif ESP32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants