Try to fix memory leaks

Author: sergeyklay

parser/parser.php5.inc.h

@@ -18,26 +18,34 @@ static void parser_add_str(zval *arr, const char *key, const char *val) {
 	zval *tmp;
 	MAKE_STD_ZVAL(tmp);
 	ZVAL_STRING(tmp, val, 1);
-	zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL);
+	if (zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL) == FAILURE) {
+		zval_ptr_dtor(&tmp);
+	}
 }
 
 static void parser_add_str_free(zval *arr, const char *key, char *val) {
 	zval *tmp;
 	MAKE_STD_ZVAL(tmp);
 	ZVAL_STRING(tmp, val, 1);
-	zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL);
+	if (zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL) == FAILURE) {
+		zval_ptr_dtor(&tmp);
+	}
 	efree(val);
 }
 
 static void parser_add_int(zval *arr, const char *key, int i) {
 	zval *tmp;
 	MAKE_STD_ZVAL(tmp);
 	ZVAL_LONG(tmp, i);
-	zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL);
+	if (zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&tmp, sizeof(zval *), NULL) == FAILURE) {
+		zval_ptr_dtor(&tmp);
+	}
 }
 
 static void parser_add_zval(zval *arr, const char *key, zval *zv) {
-	zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&zv, sizeof(zval *), NULL);
+	if (zend_hash_add(Z_ARRVAL_P(arr), key, strlen(key) + 1, (void **)&zv, sizeof(zval *), NULL) == FAILURE) {
+		zval_ptr_dtor(&zv);
+	}
 }
 
 static void parser_array_append(zval *arr, zval *zv) {

zephir_parser.c

@@ -47,7 +47,7 @@ PHP_FUNCTION(zephir_parse_file)
 #endif
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss", &content, &content_len, &filepath, &filepath_len) == FAILURE) {
-		return;
+		RETURN_FALSE;
 	}
 
 #if PHP_VERSION_ID >= 70000
@@ -63,7 +63,7 @@ PHP_FUNCTION(zephir_parse_file)
 	}
 	RETURN_ZVAL(&ret, 1, 1);
 #else
-	RETVAL_ZVAL(ret, 1, 0);
+	RETVAL_ZVAL(ret, 1, 1);
 #endif
 }
 /* }}} */
@@ -101,7 +101,10 @@ PHP_MINFO_FUNCTION(zephir_parser)
 }
 /* }}} */
 
-/* {{{ zephir_parser_functions[] */
+/* {{{ zephir_parser_functions[]
+ *
+ * Every user visible function must have an entry in zephir_parser_functions[].
+ */
 static const zend_function_entry zephir_parser_functions[] = {
 		PHP_FE(zephir_parse_file,	NULL)
 		PHP_FE_END
@@ -131,3 +134,12 @@ ZEND_TSRMLS_CACHE_DEFINE();
 #endif
 ZEND_GET_MODULE(zephir_parser)
 #endif
+
+/*
+ * Local variables:
+ * tab-width: 4
+ * c-basic-offset: 4
+ * End:
+ * vim600: noet sw=4 ts=4 fdm=marker
+ * vim<600: noet sw=4 ts=4
+ */