feat: merge object and array settings from different scopes e.g. global and workspace setting values

Author: zardoy

src/extension.ts

@@ -4,7 +4,6 @@ import { defaultJsSupersetLangs } from '@zardoy/vscode-utils/build/langs'
 import { extensionCtx, getExtensionSetting, getExtensionSettingId } from 'vscode-framework'
 import { pickObj } from '@zardoy/utils'
 import { watchExtensionSettings } from '@zardoy/vscode-utils/build/settings'
-import { Configuration } from './configurationType'
 import webImports from './webImports'
 import { sendCommand } from './sendCommand'
 import { registerEmmet } from './emmet'
@@ -28,7 +27,8 @@ export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted
     const syncConfig = () => {
         if (!tsApi) return
         console.log('sending configure request for typescript-essential-plugins')
-        const config: any = vscode.workspace.getConfiguration().get(process.env.IDS_PREFIX!)
+        const config: any = { ...vscode.workspace.getConfiguration().get(process.env.IDS_PREFIX!) }
+        // todo implement language-specific settings
         mergeSettingsFromScopes(config, 'typescript', extensionCtx.extension.packageJSON)
 
         tsApi.configurePlugin('typescript-essential-plugins', config)

src/mergeSettings.ts

@@ -1,5 +1,6 @@
 import * as vscode from 'vscode'
 import lodash from 'lodash'
+import { getExtensionContributionsPrefix } from 'vscode-framework'
 import { Configuration } from './configurationType'
 
 const settingsToIgnore = [] as Array<keyof Configuration>
@@ -14,9 +15,10 @@ export const mergeSettingsFromScopes = (
             configuration: { properties },
         },
     } = packageJson
-    for (const [key, item] of Object.entries(properties)) {
-        const isObject = item.type !== 'object'
-        if ((isObject && item.type !== 'array') || settingsToIgnore.includes(key as keyof Configuration)) {
+    for (const [fullKey, item] of Object.entries(properties)) {
+        const key = fullKey.slice(getExtensionContributionsPrefix().length)
+        const isObject = item.type === 'object'
+        if ((!isObject && item.type !== 'array') || settingsToIgnore.includes(key as keyof Configuration)) {
             continue
         }
 
@@ -28,7 +30,6 @@ export const mergeSettingsFromScopes = (
 const getConfigValueFromAllScopes = <T extends keyof Configuration>(configKey: T, language: string, type: 'array' | 'object'): Configuration[T] => {
     const values = { ...vscode.workspace.getConfiguration(process.env.IDS_PREFIX, { languageId: language }).inspect<any[]>(configKey)! }
     const userValueKeys = Object.keys(values).filter(key => key.endsWith('Value') && !key.startsWith('default'))
-    console.log(userValueKeys)
     for (const key of userValueKeys) {
         if (values[key] !== undefined) {
             continue