fix ts5 completion crash with out of the box settings

Author: zardoy

typescript/src/completionsAtPosition.ts

@@ -3,7 +3,7 @@ import inKeywordCompletions from './inKeywordCompletions'
 // import * as emmet from '@vscode/emmet-helper'
 import isInBannedPosition from './completions/isInBannedPosition'
 import { GetConfig } from './types'
-import { findChildContainingExactPosition, findChildContainingPosition } from './utils'
+import { findChildContainingExactPosition, findChildContainingPosition, isTs5 } from './utils'
 import indexSignatureAccessCompletions from './completions/indexSignatureAccess'
 import fixPropertiesSorting from './completions/fixPropertiesSorting'
 import { isGoodPositionBuiltinMethodCompletion } from './completions/isGoodPositionMethodCompletion'
@@ -60,7 +60,7 @@ export const getCompletionsAtPosition = (
         try {
             return languageService.getCompletionsAtPosition(fileName, position, options, formatOptions)
         } finally {
-            unpatch()
+            unpatch?.()
         }
     }
     let prior = getPrior()
@@ -341,6 +341,8 @@ const arrayMoveItemToFrom = <T>(array: T[], originalItem: ArrayPredicate<T>, ite
 }
 
 const patchBuiltinMethods = (c: GetConfig, languageService: ts.LanguageService, isCheckedFile: boolean) => {
+    if (isTs5 && (isCheckedFile || !c('additionalIncludeExtensions').length)) return
+
     let addFileExtensions: string[] | undefined
     const getAddFileExtensions = () => {
         const typeChecker = languageService.getProgram()!.getTypeChecker()!

typescript/src/getPatchedNavTree.ts

@@ -1,8 +1,6 @@
-import { nodeModules } from './utils'
-import * as semver from 'semver'
+import { isTs5, nodeModules } from './utils'
 import { createLanguageService } from './dummyLanguageService'
 import { getCannotFindCodes } from './utils/cannotFindCodes'
-import { Configuration } from './types'
 
 // used at testing only
 declare const __TS_SEVER_PATH__: string | undefined
@@ -83,8 +81,6 @@ const getPatchedNavModule = (additionalFeatures: AdditionalFeatures): { getNavig
         },
     ]
 
-    // semver: can't use compare as it incorrectly works with build postfix
-    const isTs5 = semver.major(ts.version) >= 5
     const {
         markerModuleStart,
         markerModuleEnd,

typescript/src/utils.ts

@@ -1,4 +1,5 @@
 import { SetOptional } from 'type-fest'
+import * as semver from 'semver'
 
 export function findChildContainingPosition(typescript: typeof ts, sourceFile: ts.SourceFile, position: number): ts.Node | undefined {
     function find(node: ts.Node): ts.Node | undefined {
@@ -116,6 +117,9 @@ export const boostExistingSuggestions = (entries: ts.CompletionEntry[], predicat
     })
 }
 
+// semver: can't use compare as it incorrectly works with build postfix
+export const isTs5 = semver.major(ts.version) >= 5
+
 // Workaround esbuild bundle modules
 export const nodeModules = __WEB__
     ? null