fix(array-methods): completions crash after [].

Author: zardoy

package.json

@@ -205,4 +205,4 @@
             "runTest": false
         }
     }
-}
+}

typescript/src/completions/arrayMethods.ts

@@ -37,7 +37,8 @@ export default (entries: ts.CompletionEntry[], position: number, sourceFile: ts.
             return c('arrayMethodsSnippets.defaultItemName')
         },
     }
-    const cleanSourceText = lowerCaseFirst(getItemNameFromNode(nodeBeforeDot)?.replace(/^(?:all)?(.+?)(?:List)?$/, '$1') ?? '') || defaultItemName.value
+    const _cleanSourceText = getItemNameFromNode(nodeBeforeDot)?.replace(/^(?:all)?(.+?)(?:List)?$/, '$1')
+    const cleanSourceText = _cleanSourceText ? lowerCaseFirst(_cleanSourceText) : defaultItemName.value
     if (!cleanSourceText) return
     let inferredName = pluralize.singular(cleanSourceText)
     // both can be undefined

typescript/test/completions.spec.ts

@@ -365,15 +365,22 @@ test('Emmet completion', () => {
 })
 
 test('Array Method Snippets', () => {
-    const positions = newFileContents(/*ts*/ `
+    const { completion } = fourslashLikeTester(/*ts*/ `
         const users = []
-        users./*|*/
-        ;users.filter(Boolean).flatMap/*|*/
+        users./*0*/
+        ;users.filter(Boolean).flatMap/*1*/
+        ;[]./*2*/
     `)
-    for (const [i, pos] of positions.entries()) {
-        const { entries } = getCompletionsAtPosition(pos) ?? {}
-        expect(entries?.find(({ name }) => name === 'flatMap')?.insertText, i.toString()).toBe('flatMap((${2:user}) => $3)')
-    }
+    completion([0, 1], {
+        includes: {
+            insertTexts: ['flatMap((${2:user}) => $3)'],
+        },
+    })
+    completion(2, {
+        includes: {
+            insertTexts: ['flatMap((${2:item}) => $3)'],
+        },
+    })
 })
 
 test('String template type completions', () => {

typescript/test/testing.ts

@@ -109,12 +109,20 @@ export const fourslashLikeTester = (contents: string, fileName = entrypoint) =>
                     }
                 }
                 if (includes) {
-                    const { names, all } = includes
+                    const { names, all, insertTexts } = includes
                     if (names) {
                         for (const name of names) {
                             expect(result?.entryNames, message).toContain(name)
                         }
                     }
+                    if (insertTexts) {
+                        for (const insertText of insertTexts) {
+                            expect(
+                                result.entries.map(entry => entry.insertText),
+                                message,
+                            ).toContain(insertText)
+                        }
+                    }
                     if (all) {
                         for (const entry of result.entries.filter(e => names?.includes(e.name))) {
                             expect(entry, entry.name + message).toContain(all)