authhelper: handle Microsoft "Permissions requested" consent screen#7387
Open
msrivas-7 wants to merge 1 commit into
Open
authhelper: handle Microsoft "Permissions requested" consent screen#7387msrivas-7 wants to merge 1 commit into
msrivas-7 wants to merge 1 commit into
Conversation
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
Signed-off-by: Mehul Srivastava <msrivas4017@gmail.com>
msrivas-7
force-pushed
the
dev/mehulsri/ms-login-consent-screen
branch
from
ebfbc39 to
a1b08d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
MsLoginAuthenticatordoesn't recognize the Microsoft "Permissions requested" user-consent screen, so flows that hit it (first-time consent for an app) fall through to "step unknown" and fail.Testing
Validated locally end-to-end against a real Microsoft Entra login that hits the "Permissions requested" consent screen, the authenticator now advances through it and completes auth successfully. Verified the happy path (no consent screen) is unaffected.
Changes
PERMISSIONS_REQUESTEDstate. Detection runs only inside the existing KMSI timeout branch, so the happy path is unchanged.Permissions requested) before clicking theidSIButton9Accept button, won't hijack the same button id used on other MS pages.Accept for your organization) is detected, logged at WARN, and skipped to avoid granting org-wide consent.Messages.propertieskey.