Update add-ons to use params add-on#7385
Conversation
| params.type.form = Form | ||
| params.type.header = Header | ||
| params.type.multipart = Multipart | ||
| params.type.unknown = Unknown |
There was a problem hiding this comment.
Do we want/need separate entries for automation?
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
|
Oops, missed adding a directory with git. Added now. |
| if (hasView()) { | ||
| extensionHook.getHookView().addOptionPanel(getOptionsFormHandlerPanel()); | ||
| if (extLoader.isExtensionEnabled(ExtensionParams.NAME)) { | ||
| if (extLoader.isExtensionEnabled(ExtensionParams2.NAME)) { | ||
| extensionHook.getHookMenu().addPopupMenuItem(getPopupMenuAddFormhandlerParam()); | ||
| } |
There was a problem hiding this comment.
Do we want to guard against this?
It won't be an issue assuming zaproxy/zaproxy#9339 is in place first.
There was a problem hiding this comment.
It's an issue for 2.17 unless we don't do releases.
There was a problem hiding this comment.
Added guards for both.
There was a problem hiding this comment.
We'll have to discuss what we want from these changes, as is it's disabling the functionality in 2.17.
| import org.zaproxy.addon.params.HtmlParameterStats; | ||
| import org.zaproxy.addon.params.ParamsPanel; | ||
| import org.zaproxy.addon.params.ParamsTableModel; | ||
|
|
There was a problem hiding this comment.
Do we want to guard against this?
It won't be an issue assuming zaproxy/zaproxy#9339 is in place first.
kingthorin
force-pushed
the
use-param
branch
2 times, most recently
from
637b437 to
376d222
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
addOns/params/src/main/java/org/zaproxy/addon/params/automation/jobs/ParamsJobResultData.java:37
- Changing the i18n prefix to
params.type.*means the existing translations for parameter types in the Automation add-on (e.g.automation.params.type.*in Messages_* locale bundles) will no longer be used. Since the params add-on currently only has an English Messages.properties, this effectively removes localized type strings in reports/automation job data for non-English users; consider migrating those translated keys into the params add-on (or keeping compatibility with the previous keys).
kingthorin
force-pushed
the
use-param
branch
6 times, most recently
from
ae3ca9b to
39703d6
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Overview
Update various add-ons to use the params add-on, instead of params functionality from core.
Related Issues