client: normalise context menu delete behaviour#7370
Open
thc202 wants to merge 1 commit into
Open
Conversation
Make it behave like the delete of the Sites tree, show it disabled if only the root node is selected (since the root node can't be deleted). Signed-off-by: thc202 <thc202@gmail.com>
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
kingthorin
reviewed
May 19, 2026
| @Override | ||
| public boolean isButtonEnabled() { | ||
| List<ClientNode> nodes = getClientMapPanel().getSelectedNodes(); | ||
| return !(nodes.size() == 1 && nodes.get(0).isRoot()); |
Member
There was a problem hiding this comment.
Does the selection always follow a top down list?
Ex: if a user control + clicks for multi-select and root is the third thing selected, will it still be the zeroth item in the list?
Member
Author
There was a problem hiding this comment.
It's fine to include the root when selecting multiple nodes, the root is simply ignored in that case. What this addresses is the case of selecting just the root node, which would prompt the user to delete but then nothing happened.
kingthorin
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it behave like the delete of the Sites tree, show it disabled if only the root node is selected (since the root node can't be deleted).