ascanrules: Add rXSS Unit Tests#7347
Open
kingthorin wants to merge 1 commit into
Open
Conversation
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional unit tests for CrossSiteScriptingScanRule, expanding coverage for reflected XSS (rXSS) scenarios and threshold-dependent behavior within the ascanrules add-on.
Changes:
- Added new unit tests covering cases like null target context at LOW threshold, JSON filtered-script behavior across thresholds, direct-attack fallback, and header-splitting paths.
- Refactored repeated Nano server response logic into small helper handler factories to support the new test cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Additional unit tests to support further/future work.