Skip to content

commonlib: Update binlist csv data from a newer source#7327

Open
kingthorin wants to merge 1 commit into
zaproxy:mainfrom
kingthorin:binlist-data
Open

commonlib: Update binlist csv data from a newer source#7327
kingthorin wants to merge 1 commit into
zaproxy:mainfrom
kingthorin:binlist-data

Conversation

@kingthorin
Copy link
Copy Markdown
Member

@kingthorin
Copy link
Copy Markdown
Member Author

pscanrules help contains references to the previous source repo. I'd like to suggest we simply remove those references.

https://github.com/search?q=repo%3Azaproxy%2Fzap-extensions+iannuttal+language%3AHTML&type=code&l=HTML

@psiinon
Copy link
Copy Markdown
Member

psiinon commented May 3, 2026

Logo
Checkmarx One – Scan Summary & Detailsd8ece971-825d-4ed8-94a3-2402c2b554c8

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the commonlib BIN dataset to align with a newer upstream source and updates BinList so the add-on can keep enriching credit-card findings in other add-ons that consume this shared library.

Changes:

  • Updated BinList CSV parsing to use the new source’s mixed-case column headers.
  • Simplified BIN lookup logic around the new source’s current 6-digit BIN format.
  • Added a changelog entry noting the BIN data source refresh.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
addOns/commonlib/src/main/java/org/zaproxy/addon/commonlib/binlist/BinList.java Adjusts CSV field extraction and BIN lookup behavior for the refreshed dataset.
addOns/commonlib/CHANGELOG.md Documents the BIN data refresh in the unreleased changelog section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread addOns/commonlib/src/main/java/org/zaproxy/addon/commonlib/binlist/BinList.java Outdated
Comment thread addOns/commonlib/src/main/java/org/zaproxy/addon/commonlib/binlist/BinList.java Outdated
Comment thread addOns/commonlib/CHANGELOG.md
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants