Skip to content

Commit b7f625c

Browse files
hughcapethughcapet
committed
Do not set aws-load-balancer-connection-idle-timeout by default
1 parent d495825 commit b7f625c

File tree

5 files changed

+14
-40
lines changed

5 files changed

+14
-40
lines changed

‎docs/administrator.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -887,15 +887,13 @@ cluster manifest. In the case any of these variables are omitted from the
887887
manifest, the operator configuration settings `enable_master_load_balancer` and
888888
`enable_replica_load_balancer` apply. Note that the operator settings affect
889889
all Postgresql services running in all namespaces watched by the operator.
890-
If load balancing is enabled two default annotations will be applied to its
891-
services:
890+
If load balancing is enabled the following default annotation will be applied to
891+
its services:
892892

893893
- `external-dns.alpha.kubernetes.io/hostname` with the value defined by the
894894
operator configs `master_dns_name_format` and `replica_dns_name_format`.
895895
This value can't be overwritten. If any changing in its value is needed, it
896896
MUST be done changing the DNS format operator config parameters; and
897-
- `service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout` with
898-
a default value of "3600".
899897

900898
There are multiple options to specify service annotations that will be merged
901899
with each other and override in the following order (where latter take

‎e2e/tests/test_e2e.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -724,14 +724,12 @@ def test_enable_disable_connection_pooler(self):
724724

725725
master_annotations = {
726726
"external-dns.alpha.kubernetes.io/hostname": "acid-minimal-cluster-pooler.default.db.example.com",
727-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
728727
}
729728
self.eventuallyTrue(lambda: k8s.check_service_annotations(
730729
master_pooler_label+","+pooler_label, master_annotations), "Wrong annotations")
731730

732731
replica_annotations = {
733732
"external-dns.alpha.kubernetes.io/hostname": "acid-minimal-cluster-pooler-repl.default.db.example.com",
734-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
735733
}
736734
self.eventuallyTrue(lambda: k8s.check_service_annotations(
737735
replica_pooler_label+","+pooler_label, replica_annotations), "Wrong annotations")

‎pkg/cluster/cluster_test.go‎

Lines changed: 12 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,7 @@ func TestServiceAnnotations(t *testing.T) {
680680
operatorAnnotations: make(map[string]string),
681681
serviceAnnotations: make(map[string]string),
682682
expect: map[string]string{
683-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
684-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
683+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
685684
},
686685
},
687686
{
@@ -702,8 +701,7 @@ func TestServiceAnnotations(t *testing.T) {
702701
operatorAnnotations: make(map[string]string),
703702
serviceAnnotations: make(map[string]string),
704703
expect: map[string]string{
705-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
706-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
704+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
707705
},
708706
},
709707
{
@@ -714,8 +712,7 @@ func TestServiceAnnotations(t *testing.T) {
714712
operatorAnnotations: make(map[string]string),
715713
serviceAnnotations: map[string]string{"foo": "bar"},
716714
expect: map[string]string{
717-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
718-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
715+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
719716
"foo": "bar",
720717
},
721718
},
@@ -737,9 +734,7 @@ func TestServiceAnnotations(t *testing.T) {
737734
operatorAnnotations: map[string]string{"foo": "bar"},
738735
serviceAnnotations: make(map[string]string),
739736
expect: map[string]string{
740-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
741-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
742-
"foo": "bar",
737+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
743738
},
744739
},
745740
{
@@ -780,8 +775,7 @@ func TestServiceAnnotations(t *testing.T) {
780775
"external-dns.alpha.kubernetes.io/hostname": "wrong.external-dns-name.example.com",
781776
},
782777
expect: map[string]string{
783-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
784-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
778+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
785779
},
786780
},
787781
{
@@ -792,8 +786,7 @@ func TestServiceAnnotations(t *testing.T) {
792786
serviceAnnotations: make(map[string]string),
793787
operatorAnnotations: make(map[string]string),
794788
expect: map[string]string{
795-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
796-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
789+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg.test.db.example.com,test-stg.acid.db.example.com",
797790
},
798791
},
799792
{
@@ -835,8 +828,7 @@ func TestServiceAnnotations(t *testing.T) {
835828
operatorAnnotations: make(map[string]string),
836829
serviceAnnotations: make(map[string]string),
837830
expect: map[string]string{
838-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
839-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
831+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
840832
},
841833
},
842834
{
@@ -857,8 +849,7 @@ func TestServiceAnnotations(t *testing.T) {
857849
operatorAnnotations: make(map[string]string),
858850
serviceAnnotations: make(map[string]string),
859851
expect: map[string]string{
860-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
861-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
852+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
862853
},
863854
},
864855
{
@@ -869,8 +860,7 @@ func TestServiceAnnotations(t *testing.T) {
869860
operatorAnnotations: make(map[string]string),
870861
serviceAnnotations: map[string]string{"foo": "bar"},
871862
expect: map[string]string{
872-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
873-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
863+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
874864
"foo": "bar",
875865
},
876866
},
@@ -892,8 +882,7 @@ func TestServiceAnnotations(t *testing.T) {
892882
operatorAnnotations: map[string]string{"foo": "bar"},
893883
serviceAnnotations: make(map[string]string),
894884
expect: map[string]string{
895-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
896-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
885+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
897886
"foo": "bar",
898887
},
899888
},
@@ -935,8 +924,7 @@ func TestServiceAnnotations(t *testing.T) {
935924
"external-dns.alpha.kubernetes.io/hostname": "wrong.external-dns-name.example.com",
936925
},
937926
expect: map[string]string{
938-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
939-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
927+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
940928
},
941929
},
942930
{
@@ -947,8 +935,7 @@ func TestServiceAnnotations(t *testing.T) {
947935
serviceAnnotations: make(map[string]string),
948936
operatorAnnotations: make(map[string]string),
949937
expect: map[string]string{
950-
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
951-
"service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout": "3600",
938+
"external-dns.alpha.kubernetes.io/hostname": "acid-test-stg-repl.test.db.example.com,test-stg-repl.acid.db.example.com",
952939
},
953940
},
954941
{

‎pkg/cluster/connection_pooler.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -533,10 +533,6 @@ func (c *Cluster) generatePoolerServiceAnnotations(role PostgresRole, spec *acid
533533
annotations := c.getCustomServiceAnnotations(role, spec)
534534

535535
if c.shouldCreateLoadBalancerForPoolerService(role, spec) {
536-
// set ELB Timeout annotation with default value
537-
if _, ok := annotations[constants.ElbTimeoutAnnotationName]; !ok {
538-
annotations[constants.ElbTimeoutAnnotationName] = constants.ElbTimeoutAnnotationValue
539-
}
540536
// -repl suffix will be added by replicaDNSName
541537
clusterNameWithPoolerSuffix := c.connectionPoolerName(Master)
542538
if role == Master {

‎pkg/cluster/k8sres.go‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2047,11 +2047,6 @@ func (c *Cluster) generateServiceAnnotations(role PostgresRole, spec *acidv1.Pos
20472047
if c.shouldCreateLoadBalancerForService(role, spec) {
20482048
dnsName := c.dnsName(role)
20492049

2050-
// Just set ELB Timeout annotation with default value, if it does not
2051-
// have a custom value
2052-
if _, ok := annotations[constants.ElbTimeoutAnnotationName]; !ok {
2053-
annotations[constants.ElbTimeoutAnnotationName] = constants.ElbTimeoutAnnotationValue
2054-
}
20552050
// External DNS name annotation is not customizable
20562051
annotations[constants.ZalandoDNSNameAnnotation] = dnsName
20572052
}

0 commit comments

Comments
 (0)