Skip to content

Syncronise protobuf versions #8

@mikhainin

Description

@mikhainin

In the repo, we can see 2 different versions of Protobuf.

4.22.5 (aka 22.5, aka 4022005), in contrib/libs/protobuf, probably not used?

#define GOOGLE_PROTOBUF_VERSION 4022005

The same here:

4.22.5 (aka 22.5, aka 4022005) in contrib/libs/protoc
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/contrib/libs/protoc/src/google/protobuf/compiler/plugin.pb.h#L18C5-L18C12

The same recommendation is in the BUILD.md
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/BUILD.md?plain=1#L47

However, before the build, another version is installed by Conan:
3.21.12 (aka 21.12, 3021012)
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/conanfile.py#L21

From what I can see, there is no 4.22.* in the Conan repo. It's probably worth either removing the Conan version completely or bumping versions everywhere.

When different versions meet at compile- or run-time, we may (and do) see unwanted artefacts - sometimes code doesn't compile, sometimes we can face various crashes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions