From 9b95eecee0bda94c0ded14e5d0a392748f93baf0 Mon Sep 17 00:00:00 2001 From: cameronapak Date: Fri, 9 Jan 2026 12:11:52 -0600 Subject: [PATCH] feat(verse-of-the-day): update default bible version to niv The default Bible version for the VerseOfTheDay component has been updated from KJV (version ID 1) to NIV (version ID 111). This change reflects the new required default version for the application. Mock data and handlers have been updated to reflect the new default version. --- packages/ui/src/components/verse-of-the-day.stories.tsx | 2 +- packages/ui/src/components/verse-of-the-day.tsx | 6 +++--- packages/ui/src/test/mock-data/passages.json | 2 +- packages/ui/src/test/mocks/handlers.ts | 6 +----- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/ui/src/components/verse-of-the-day.stories.tsx b/packages/ui/src/components/verse-of-the-day.stories.tsx index 77f9c35..cebb8df 100644 --- a/packages/ui/src/components/verse-of-the-day.stories.tsx +++ b/packages/ui/src/components/verse-of-the-day.stories.tsx @@ -79,7 +79,7 @@ export const Default: Story = { const callArgs = mockSpy.mock.calls[0]?.[0]; await expect(callArgs).toHaveProperty('text'); await expect(callArgs?.text).toContain('For I am about to do something new'); - await expect(callArgs?.text).toContain('Isaiah 43:19 KJV'); + await expect(callArgs?.text).toContain('Isaiah 43:19 NIV'); }, }; diff --git a/packages/ui/src/components/verse-of-the-day.tsx b/packages/ui/src/components/verse-of-the-day.tsx index 67f404f..47763c1 100644 --- a/packages/ui/src/components/verse-of-the-day.tsx +++ b/packages/ui/src/components/verse-of-the-day.tsx @@ -19,7 +19,7 @@ export type VerseOfTheDayProps = { */ background?: 'light' | 'dark'; /** - * The Bible Translation version id to use, defaults to 1 (KJV). + * The Bible Translation version id to use, defaults to 111 (NIV). */ versionId?: number; /** @@ -69,7 +69,7 @@ async function share({ title, text, url }: { title?: string; text: string; url?: * @example * ```tsx *
19For I am about to do something new.
See, I have already begun! Do you not see it?
I will make a pathway through the wilderness.
I will create rivers in the dry wasteland.
", - "version_id": 1, + "version_id": 111, "reference": "Isaiah 43:19" }, "JHN.1.51": { diff --git a/packages/ui/src/test/mocks/handlers.ts b/packages/ui/src/test/mocks/handlers.ts index 4d5bed4..9240aff 100644 --- a/packages/ui/src/test/mocks/handlers.ts +++ b/packages/ui/src/test/mocks/handlers.ts @@ -47,7 +47,7 @@ export const globalHandlers = [ }), // Isaiah passage for verse of the day - http.get('*/v1/bibles/1/passages/ISA.43.19', () => { + http.get('*/v1/bibles/111/passages/ISA.43.19', () => { return HttpResponse.json(mockPassages['ISA.43.19']); }), @@ -56,10 +56,6 @@ export const globalHandlers = [ return HttpResponse.json(mockBibles.individual['111']); }), - http.get('*/v1/bibles/1', () => { - return HttpResponse.json(mockBibles.individual['1']); - }), - http.get('*/v1/bibles/1588', () => { return HttpResponse.json(mockBibles.individual['1588']); }),