From 938767600c40643bfacc26b7d4f8f011ae19feef Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 23 Jun 2026 06:18:23 +0000 Subject: [PATCH 1/2] Optimize regex compilation in ContentService Move regex pattern from inside the loop to a class constant to avoid redundant re-definitions. Co-authored-by: yilanboy <27554321+yilanboy@users.noreply.github.com> --- app/Services/ContentService.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Services/ContentService.php b/app/Services/ContentService.php index 260227dd..256b01ad 100644 --- a/app/Services/ContentService.php +++ b/app/Services/ContentService.php @@ -10,6 +10,8 @@ class ContentService { + private const IMAGE_PATTERN = '/\d{4}_\d{2}_\d{2}_\d{2}_\d{2}_\d{2}_[a-zA-Z0-9]+\.(jpeg|png|jpg|gif|svg)/u'; + /** * 生成用來優化 SEO 的 slug * @@ -66,11 +68,9 @@ public static function getImagesInContent(string $body): array $imageList = []; foreach ($dom->getElementsByTagName('img') as $img) { - $pattern = '/\d{4}_\d{2}_\d{2}_\d{2}_\d{2}_\d{2}_[a-zA-Z0-9]+\.(jpeg|png|jpg|gif|svg)/u'; - $imageName = basename($img->getAttribute('src')); - if (preg_match($pattern, $imageName)) { + if (preg_match(self::IMAGE_PATTERN, $imageName)) { $imageList[] = $imageName; } } From 0d95abc8428ba454765435797e3211ad61d5bce2 Mon Sep 17 00:00:00 2001 From: Allen Date: Tue, 23 Jun 2026 14:26:12 +0800 Subject: [PATCH 2/2] chore: update image pattern regex to include bmp and webp extensions --- app/Services/ContentService.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Services/ContentService.php b/app/Services/ContentService.php index 256b01ad..2474d1d3 100644 --- a/app/Services/ContentService.php +++ b/app/Services/ContentService.php @@ -10,7 +10,7 @@ class ContentService { - private const IMAGE_PATTERN = '/\d{4}_\d{2}_\d{2}_\d{2}_\d{2}_\d{2}_[a-zA-Z0-9]+\.(jpeg|png|jpg|gif|svg)/u'; + private const string IMAGE_PATTERN = '/\d{4}_\d{2}_\d{2}_\d{2}_\d{2}_\d{2}_[a-zA-Z0-9]+\.(jpg|jpeg|png|bmp|gif|webp)/u'; /** * 生成用來優化 SEO 的 slug