lint, update action yml

Author: qrort

.github/workflows/slo.yml

@@ -45,26 +45,44 @@ jobs:
             name: database-sql-table
             path: ./database/sql/table
             label: database/sql/table
+            run_extra_args: ''
+            create_extra_args: ''
           - id: database_sql_query
             name: database-sql-query
             path: ./database/sql/query
             label: database/sql/query
+            run_extra_args: ''
+            create_extra_args: ''
           - id: native_query
             name: native-query
             path: ./native/query
             label: native/query
+            run_extra_args: ''
+            create_extra_args: ''
           - id: native_table
             name: native-table
             path: ./native/table
             label: native/table
+            run_extra_args: ''
+            create_extra_args: ''
           - id: native_table_over_query_service
             name: native-table-over-query-service
             path: ./native/table/over/query/service
             label: native/table/over/query/service
+            run_extra_args: ''
+            create_extra_args: ''
           - id: native_bulk_upsert
             name: native-bulk-upsert
             path: ./native/bulk-upsert
             label: native/bulk-upsert
+            run_extra_args: '-batch-size=10'
+            create_extra_args: ''
+          - id: native_node_hints
+            name: native-node-hints
+            path: ./native/node_hints
+            label: native/node_hints
+            run_extra_args: '-prometheus-endpoint http://172.28.0.2:9090 -batch-size=10'
+            create_extra_args: '-min-partitions-count 10'
 
     concurrency:
       group: slo-${{ github.ref }}-${{ matrix.sdk.name }}
@@ -180,35 +198,33 @@ jobs:
           fi
 
       - name: Initialize YDB SLO
-        uses: ydb-platform/ydb-slo-action/init@main
+        uses: ydb-platform/ydb-slo-action/init@21473ae781c9bc8f16b42dedc79489c1867c6e50
         with:
           github_issue: ${{ github.event.inputs.github_issue }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
           workload_name: ${{ matrix.sdk.name }}
           workload_current_ref: ${{ github.head_ref || github.ref_name }}
           workload_baseline_ref: ${{ steps.baseline.outputs.ref }}
+          disable_compose_profiles: "${{ matrix.sdk.id == 'native_node_hints' && 'chaos' || '' }}"
 
       - name: Prepare SLO Database
         run: |
           echo "Preparing SLO database..."
+          CREATE_EXTRA_ARGS="${{ matrix.sdk.create_extra_args }}"
           docker run --rm --network ydb_ydb-net \
             --add-host "ydb:172.28.0.11" \
             --add-host "ydb:172.28.0.12" \
             --add-host "ydb:172.28.0.13" \
             --add-host "ydb:172.28.0.99" \
-            ydb-app-current create grpc://ydb:2136 /Root/testdb
+            ydb-app-current create grpc://ydb:2136 /Root/testdb $CREATE_EXTRA_ARGS
 
       - name: Run SLO Tests (parallel)
         timeout-minutes: 15
         run: |
           DURATION=${{ inputs.slo_workload_duration_seconds || 600 }}
           READ_RPS=${{ inputs.slo_workload_read_max_rps || 1000 }}
           WRITE_RPS=${{ inputs.slo_workload_write_max_rps || 1000 }}
-
-          EXTRA_ARGS=""
-          if [ "${{ matrix.sdk.id }}" = "native_bulk_upsert" ]; then
-            EXTRA_ARGS="--batch-size=10"
-          fi
+          RUN_EXTRA_ARGS="${{ matrix.sdk.run_extra_args }}"
 
           ARGS="run grpc://ydb:2136 /Root/testdb \
             -otlp-endpoint prometheus:9090 \
@@ -218,7 +234,7 @@ jobs:
             -write-rps $WRITE_RPS \
             -read-timeout 100 \
             -write-timeout 100 \
-            $EXTRA_ARGS"
+            $RUN_EXTRA_ARGS"
 
           echo "Starting ydb-app-current..."
           docker run -d \

tests/slo/internal/generator/generator.go

@@ -17,18 +17,18 @@ type Generator interface {
 	Generate() (Row, error)
 }
 
-type GeneratorImpl struct {
+type Impl struct {
 	currentID RowID
 	mu        sync.Mutex
 }
 
-func New(id RowID) *GeneratorImpl {
-	return &GeneratorImpl{
+func New(id RowID) *Impl {
+	return &Impl{
 		currentID: id,
 	}
 }
 
-func (g *GeneratorImpl) Generate() (Row, error) {
+func (g *Impl) Generate() (Row, error) {
 	g.mu.Lock()
 	id := g.currentID
 	g.currentID++

tests/slo/internal/generator/seeded.go

@@ -46,6 +46,7 @@ func (g *SeededGenerator) Generate() (Row, error) {
 	} else {
 		row.ID = g.setRange.Left + g.rng.Uint64()%(g.setRange.Right-g.setRange.Left)
 	}
+
 	return row, nil
 }
 
@@ -54,4 +55,4 @@ func (g *SeededGenerator) SetRange(l uint64, r uint64) {
 		Left:  l,
 		Right: r,
 	}
-}
+}

tests/slo/internal/node_hints/node_hints.go

@@ -6,14 +6,15 @@ import (
 	"log"
 	"math/rand"
 	"slices"
-	"slo/internal/generator"
 	"sync/atomic"
 	"time"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/options"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
+
+	"slo/internal/generator"
 )
 
 func describeTable(ctx context.Context, driver *ydb.Driver, tableName string) (desc options.Description, err error) {
@@ -25,10 +26,12 @@ func describeTable(ctx context.Context, driver *ydb.Driver, tableName string) (d
 				options.WithShardKeyBounds(),
 				options.WithShardNodesInfo(),
 			)
+
 			return err
 		},
 		table.WithIdempotent(),
 	)
+
 	return desc, err
 }
 
@@ -42,9 +45,9 @@ func extractKey(v types.Value, side int) (uint64, error) {
 	if types.IsNull(v) {
 		if side == LEFT {
 			return 0, nil
-		} else {
-			return ^uint64(0), nil
 		}
+
+		return ^uint64(0), nil
 	}
 	parts, err := types.TupleItems(v)
 	if err != nil {
@@ -66,7 +69,6 @@ const (
 
 func MakeNodeSelector(ctx context.Context, driver *ydb.Driver, tableName string) (*NodeSelector, error) {
 	dsc, err := describeTable(ctx, driver, tableName)
-
 	if err != nil {
 		return nil, err
 	}
@@ -98,60 +100,70 @@ func MakeNodeSelector(ctx context.Context, driver *ydb.Driver, tableName string)
 	for _, ps := range dsc.Stats.PartitionStats {
 		s.NodeIDs = append(s.NodeIDs, ps.LeaderNodeID)
 	}
+
 	return &s, nil
 }
 
-func (s *NodeSelector) findNodeID(key uint64) uint32 {
-	idx, found := slices.BinarySearch(s.UpperBounds, key)
+func (ns *NodeSelector) findNodeID(key uint64) uint32 {
+	idx, found := slices.BinarySearch(ns.UpperBounds, key)
 	if found {
 		idx++
 	}
-	return s.NodeIDs[idx]
+
+	return ns.NodeIDs[idx]
 }
 
-func (s *NodeSelector) WithNodeHint(ctx context.Context, key uint64) context.Context {
-	if s == nil || len(s.NodeIDs) == 0 {
+func (ns *NodeSelector) WithNodeHint(ctx context.Context, key uint64) context.Context {
+	if ns == nil || len(ns.NodeIDs) == 0 {
 		return ctx
 	}
-	return ydb.WithPreferredNodeID(ctx, s.findNodeID(key))
+
+	return ydb.WithPreferredNodeID(ctx, ns.findNodeID(key))
 }
 
-func (s *NodeSelector) GeneratePartitionKey(partitionId uint64) uint64 {
-	l := s.UpperBounds[partitionId] - s.LowerBounds[partitionId]
-	return s.LowerBounds[partitionId] + rand.Uint64()%l
+func (ns *NodeSelector) GeneratePartitionKey(partitionID uint64) uint64 {
+	l := ns.UpperBounds[partitionID] - ns.LowerBounds[partitionID]
+
+	return ns.LowerBounds[partitionID] + rand.Uint64()%l
 }
 
-func RunUpdates(ctx context.Context, driver *ydb.Driver, tableName string, frequency time.Duration) (*atomic.Pointer[NodeSelector], error) {
+func RunUpdates(
+	ctx context.Context,
+	driver *ydb.Driver,
+	tableName string,
+	frequency time.Duration,
+) (*atomic.Pointer[NodeSelector], error) {
 	var ns atomic.Pointer[NodeSelector]
 	updateSelector := func() error {
 		selector, err := MakeNodeSelector(ctx, driver, tableName)
 		if err != nil {
 			return err
 		}
 		ns.Store(selector)
+
 		return nil
 	}
 
 	err := updateSelector()
 	if err != nil {
 		return nil, err
-	} else {
-		ticker := time.NewTicker(frequency)
-		go func() {
-			defer ticker.Stop()
-			for {
-				select {
-				case <-ctx.Done():
-					return
-				case <-ticker.C:
-					err = updateSelector()
-					if err != nil {
-						log.Printf("node hints update error: %v\n", err)
-					}
+	}
+	ticker := time.NewTicker(frequency)
+	go func() {
+		defer ticker.Stop()
+		for {
+			select {
+			case <-ctx.Done():
+				return
+			case <-ticker.C:
+				err = updateSelector()
+				if err != nil {
+					log.Printf("node hints update error: %v\n", err)
 				}
 			}
-		}()
-	}
+		}
+	}()
+
 	return &ns, nil
 }
 
@@ -167,5 +179,6 @@ func (ns *NodeSelector) GetRandomNodeID(generator generator.Generator) (int, uin
 		}
 	}
 	log.Panicf("GetRandomNodeID: no nodeID found for shift: %d", shift)
+
 	return 0, 0
 }

tests/slo/internal/workers/read.go

@@ -41,6 +41,7 @@ func (w *Workers) ReadID() uint64 {
 	if err != nil {
 		log.Panicf("generate error: %v", err)
 	}
+
 	return row.ID
 }
 
@@ -57,6 +58,7 @@ func (w *Workers) ReadIDs() []uint64 {
 			ids = append(ids, row.ID)
 		}
 	}
+
 	return ids
 }