Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Dec 4, 2025

Closes #3144

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 62.34 MB | Main: 62.34 MB
Diff: 0.59 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot AI review requested due to automatic review settings December 4, 2025 11:46
Copilot finished reviewing on behalf of astandrik December 4, 2025 11:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates operation status and progress information into a single Status column, addressing issue #3144. The change removes the separate Progress column and implements smarter status display logic that shows progress information for in-progress operations, including a workaround for operations that report SUCCESS status before completion.

Key Changes:

  • Removed the dedicated Progress column from the operations table
  • Integrated progress information into the Status column with intelligent display logic
  • Added handling for edge case where operations have status: SUCCESS but ready: false

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/containers/Operations/i18n/en.json Removed "column_progress" label and added "label_in-progress" for in-progress operations
src/containers/Operations/constants.ts Removed PROGRESS column constant and its title mapping
src/containers/Operations/columns.tsx Added renderStatusCell function to intelligently display status/progress, removed separate progress column logic and unused IMPORT_EXPORT_KINDS constant

@astandrik astandrik requested a review from Copilot December 4, 2025 15:59
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copilot finished reviewing on behalf of astandrik December 4, 2025 16:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

success workaround for operations list

2 participants