-
Notifications
You must be signed in to change notification settings - Fork 17
fix: success workaround for operations list #3176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates operation status and progress information into a single Status column, addressing issue #3144. The change removes the separate Progress column and implements smarter status display logic that shows progress information for in-progress operations, including a workaround for operations that report SUCCESS status before completion.
Key Changes:
- Removed the dedicated Progress column from the operations table
- Integrated progress information into the Status column with intelligent display logic
- Added handling for edge case where operations have
status: SUCCESSbutready: false
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Operations/i18n/en.json | Removed "column_progress" label and added "label_in-progress" for in-progress operations |
| src/containers/Operations/constants.ts | Removed PROGRESS column constant and its title mapping |
| src/containers/Operations/columns.tsx | Added renderStatusCell function to intelligently display status/progress, removed separate progress column logic and unused IMPORT_EXPORT_KINDS constant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Closes #3144
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.34 MB | Main: 62.34 MB
Diff: 0.59 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information