Improve error handling in analysis.service.js

[coderabbitai]

Problem

The analysis service has weak error handling that can lead to silent failures and incomplete analysis:

Critical Issues

1. Missing data validation: Continues execution with empty diffText or filesList if fetches fail
2. Comment posting failure: Errors are logged but job still succeeds, leaving no PR feedback
3. No timeouts: Axios calls can hang indefinitely
4. Silent email failures: Email errors swallowed with empty catch blocks

Non-Critical Issues

• Email/diff/files fetch errors only logged with console.warn
• No structured error context for debugging

Action Items

1. Add timeout configuration to all axios calls
2. Validate that critical data (diff, files) exists before LLM call
3. Fail the job if comment posting fails (critical operation)
4. Add proper error logging for email failures
5. Consider circuit breaker pattern for external API calls
6. Add retry with exponential backoff for transient failures

File

backend/services/analysis.service.js

Related

• PR Idempotent pr analysis built #28
• Comment: Idempotent pr analysis built #28 (comment)

Requested by: @yb175