test: relocate basic Qdrant connectivity test to smoke tier (#2069)#2074
Open
yastman wants to merge 1 commit into
Open
test: relocate basic Qdrant connectivity test to smoke tier (#2069)#2074yastman wants to merge 1 commit into
yastman wants to merge 1 commit into
Conversation
tests/integration/test_basic_connection.py is a connectivity-only Qdrant ping (urllib + GET /collections). It does not exercise an integration — it just probes whether the service answers. Per the test-audit triage in #1515, that belongs in tests/smoke/ alongside other live-service probes (test_chunking_smoke, test_smoke_bge_litellm_cache, etc.). Changes: - git mv tests/integration/test_basic_connection.py tests/smoke/test_basic_connection.py - Update tests/unit/security/test_codeql_regressions.py path constant. - Update tests/unit/security/test_secret_hygiene.py path expression. Verification: uv run pytest tests/smoke/test_basic_connection.py --co -q 1 test collected uv run pytest tests/smoke/test_basic_connection.py --collect-only -> smoke marker applied automatically (root conftest tier rule). uv run pytest tests/unit/security/test_codeql_regressions.py tests/unit/security/test_secret_hygiene.py -q 9 passed The smoke marker is auto-applied by tests/conftest.py pytest_collection_modifyitems based on the parent directory, so no explicit pytestmark = pytest.mark.smoke is needed on the file. Closes #2069
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @yastman 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Summary
tests/integration/test_basic_connection.pyis a connectivity-only Qdrant ping (urllib +GET /collections). It doesn't exercise an integration — it just probes whether the service answers. Per the test-audit triage in #1515, that belongs intests/smoke/alongside other live-service probes.Changes
git mv tests/integration/test_basic_connection.py tests/smoke/test_basic_connection.pytests/unit/security/test_codeql_regressions.pypath constant.tests/unit/security/test_secret_hygiene.pypath expression.Verification
The
smokemarker is auto-applied bytests/conftest.py::pytest_collection_modifyitemsbased on parent directory, so no explicitpytestmark = pytest.mark.smokeis needed.Closes #2069