-
Notifications
You must be signed in to change notification settings - Fork 4
Re-enable @ark/attest completion snapshots for Issue #796 #895
Copy link
Copy link
Open
Labels
arkenvChanges to the `arkenv` npm package.Changes to the `arkenv` npm package.blockedWork cannot proceed; waiting on something elseWork cannot proceed; waiting on something elseenhancementNew feature or requestNew feature or requestready for humanRequires human implementationRequires human implementationtestsThis issue or PR is about adding, removing or changing testsThis issue or PR is about adding, removing or changing tests
Metadata
Metadata
Assignees
Labels
arkenvChanges to the `arkenv` npm package.Changes to the `arkenv` npm package.blockedWork cannot proceed; waiting on something elseWork cannot proceed; waiting on something elseenhancementNew feature or requestNew feature or requestready for humanRequires human implementationRequires human implementationtestsThis issue or PR is about adding, removing or changing testsThis issue or PR is about adding, removing or changing tests
Summary
The type regression tests implemented in #894 currently use Vitest's built-in
expectTypeOffor inference checking. Direct completion snapshots (using.completions()) are currently commented out due to a version conflict between@ark/attest@0.56.0andarktype@2.2.0.Context
Issue #796 identified a regression where string literal autocompletions for ArkType DSL values were lost. While
expectTypeOfverifies that the types evaluate correctly,@ark/attestis the essentially only tool that can directly snapshot the IDE completion suggestions to ensure the developer experience doesn't regress.Implementation Steps (Follow-up)
Once the upstream conflict is resolved (see arktypeio/arktype#1617):
packages/arkenv/src/type-regression.test-d.ts:it("snapshots DSL completions ...")block.attestcalls.globalSetupinpackages/arkenv/vitest.config.ts:globalSetup: ["test/setup-attest.ts"].pnpm test:types(which should now execute both Vitest typechecks and Attest snapshots).vitest run --update-snapshots.Dependencies
@ark/attestcompatibility witharktype@2.2.0: [attest] ParseError: "A Scope already named Array already exists" when used with arktype@2.2.0 arktypeio/arktype#1617