Update all the things (#213)

* maint: updating all the things, adding more testing, more debug information

Author: yaleman

.github/workflows/mypy.yml

@@ -12,12 +12,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-        with:
-          fetch-depth: 0    # Fetch all history for .GitInfo and .Lastmod
       - name: Set up Python
         uses: actions/setup-python@v6
         with:
-          python-version: '3.12'
+          python-version: "3.13"
       - name: Running mypy
         run: |
           python -m pip install --quiet --no-cache-dir --upgrade uv

.github/workflows/pylint.yml

@@ -12,13 +12,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-        with:
-          fetch-depth: 0    # Fetch all history for .GitInfo and .Lastmod
       - name: Set up Python
         uses: actions/setup-python@v6
         with:
-          python-version: '3.12'
+          python-version: "3.13"
       - name: Running tests
         run: |
-            python -m pip install --quiet --no-cache-dir --upgrade uv
-            uv run ruff check $(basename $(pwd) | sed -E 's/-/_/g') tests/
+          python -m pip install --quiet --no-cache-dir --upgrade uv
+          uv run ruff check $(basename $(pwd) | sed -E 's/-/_/g') tests/

.github/workflows/pytest.yml

@@ -12,14 +12,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-        with:
-          fetch-depth: 0    # Fetch all history for .GitInfo and .Lastmod
       - name: Set up Python
         uses: actions/setup-python@v6
         with:
-          python-version: '3.12'
+          python-version: "3.13"
       - name: Running pytest
+        env:
+          COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
         run: |
-          python --version
           python -m pip install --quiet --no-cache-dir --upgrade uv
-          uv pytest
+          uv run pytest
+          uv run coverage run --source=thin_controller -m pytest
+          uv run coveralls

.gitignore

@@ -24,3 +24,4 @@ terraform/local.tf
 terraform/.terraform/
 terraform/thin_controller_layer/
 terraform/*.zip
+.coverage

.python-version

@@ -0,0 +1 @@
+3.13

justfile

@@ -4,7 +4,7 @@ default:
 check: lint types test
 
 coverage:
-    uv run coverage run -m pytest
+    uv run coverage run --source=thin_controller -m pytest
     uv run coveralls
 
 

pyproject.toml

@@ -27,6 +27,10 @@ dev = [
     "pytest>=8.3.5,<9.0.0",
     "types-boto3>=1.37.36,<2.0.0",
     "pyright>=1.1.400",
+    "coverage>=7.10.7",
+    "coveralls>=4.0.1",
+    "pytest-cov>=7.0.0",
+    "httpx>=0.28.1",
 ]
 
 
@@ -37,6 +41,7 @@ thin-controller = "thin_controller.__main__:cli"
 
 [tool.pylint.MASTER]
 max-line-length = 200
+load-plugins = "pylint_pytest"
 
 [tool.pytest.ini_options]
 testpaths = ["tests"]
@@ -48,4 +53,8 @@ plugins = "pydantic.mypy"
 exclude = ["terraform", ".venv"]
 
 [tool.coverage.run]
-omit = ["tests/*", "terraform/*"]
+omit = [
+    "tests/*",                    # don't test the tests
+    "terraform/*",                # no python here
+    "thin_controller/handler.py", # only a stub for the Lambda handler
+]

terraform/main.tf

@@ -7,7 +7,7 @@ resource "terraform_data" "thin_controller_layer" {
   triggers_replace = data.archive_file.thin_controller_layer
 
   provisioner "local-exec" {
-    command = "python3.12 -m pip install --upgrade -t ./thin_controller_layer/ ../"
+    command = "python3.13 -m pip install --upgrade -t ./thin_controller_layer/ ../"
   }
 
 }
@@ -22,7 +22,7 @@ resource "aws_lambda_layer_version" "thin_controller" {
   layer_name = "thin_controller"
 
   compatible_runtimes = [
-    "python3.12"
+    "python3.13"
   ]
 }
 
@@ -32,7 +32,7 @@ module "thin_controller_module" {
 
   function_name  = "thin_controller"
   lambda_handler = "handler.handler"
-  lambda_runtime = "python3.12"
+  lambda_runtime = "python3.13"
 
   aws_region     = var.aws_region
   aws_profile    = var.aws_profile
@@ -99,4 +99,4 @@ module "thin_controller_module" {
 #     }
 #   }
 
-# }
+# }

tests/test_api.py

@@ -0,0 +1,65 @@
+"""test API things"""
+
+import os
+import sys
+
+from fastapi.testclient import TestClient
+import pytest
+from loguru import logger
+from thin_controller import app
+
+logger.remove()
+logger.add(sys.stderr, level="DEBUG")
+
+
+@pytest.fixture(scope="function")
+def client() -> TestClient:
+    """Create a test client for the FastAPI app."""
+    return TestClient(app)
+
+
+def test_index(client: TestClient) -> None:
+    """Test the main endpoint."""
+
+    response = client.get("/")
+    assert response.status_code == 200
+    assert "Thin Controller" in response.content.decode()
+
+
+def test_css(client: TestClient) -> None:
+    """Test the main endpoint."""
+
+    for url in ["/css/styles.css", "/css/simple.min.css"]:
+        response = client.get(url)
+        assert response.status_code == 200
+
+    assert client.get("/css/doesnotexist.css").status_code == 404
+
+
+def test_favicon(client: TestClient) -> None:
+    """Test the favicon endpoint."""
+
+    response = client.get("/img/favicon.png")
+    assert response.status_code == 200
+
+    assert client.get("/img/doesnotexist.png").status_code == 404
+
+
+def test_api_config(client: TestClient) -> None:
+    """Test the config endpoint."""
+
+    response = client.get("/api/config")
+    assert response.status_code == 200
+    assert "regions" in response.json()
+
+
+def test_read_instance(client: TestClient) -> None:
+    """Test the instance read endpoint."""
+
+    response = client.get("/api/instances")
+    print(response.content)
+    if os.getenv("AWS_ACCESS_KEY_ID") is None:
+        assert response.status_code == 500
+    else:
+        assert response.status_code == 200
+    assert isinstance(response.json(), dict)

tests/test_main.py

@@ -0,0 +1,9 @@
+"""testing the main func"""
+
+from thin_controller.__main__ import cli
+
+
+def test_cli_help() -> None:
+    """Test that the CLI help command works."""
+    result = cli(["--help"], standalone_mode=False)
+    assert result == 0