chore: add return types

Author: yajra

tests/DataTableServiceTest.php

@@ -15,7 +15,7 @@ class DataTableServiceTest extends TestCase
     use DatabaseTransactions;
 
     /** @test */
-    public function it_can_handle_ajax_request()
+    public function it_can_handle_ajax_request(): void
     {
         $response = $this->getAjax('/users');
 
@@ -27,7 +27,7 @@ public function it_can_handle_ajax_request()
     }
 
     /** @test */
-    public function it_returns_view_on_normal_get_request()
+    public function it_returns_view_on_normal_get_request(): void
     {
         $response = $this->get('users');
 
@@ -36,31 +36,31 @@ public function it_returns_view_on_normal_get_request()
     }
 
     /** @test */
-    public function it_can_return_a_csv_file()
+    public function it_can_return_a_csv_file(): void
     {
         $response = $this->get('users?action=csv');
 
         $this->assertInstanceOf(BinaryFileResponse::class, $response->baseResponse);
     }
 
     /** @test */
-    public function it_can_return_a_xls_file()
+    public function it_can_return_a_xls_file(): void
     {
         $response = $this->get('users?action=excel');
 
         $this->assertInstanceOf(BinaryFileResponse::class, $response->baseResponse);
     }
 
     /** @test */
-    public function it_can_return_a_pdf_file()
+    public function it_can_return_a_pdf_file(): void
     {
         $response = $this->get('users?action=pdf');
 
         $this->assertInstanceOf(Response::class, $response->baseResponse);
     }
 
     /** @test */
-    public function it_allows_before_response_callback()
+    public function it_allows_before_response_callback(): void
     {
         $response = $this->getAjax('users/before');
         $response->assertOk();
@@ -70,7 +70,7 @@ public function it_allows_before_response_callback()
     }
 
     /** @test */
-    public function it_allows_response_callback()
+    public function it_allows_response_callback(): void
     {
         $response = $this->getAjax('users/response');
         $response->assertOk();

tests/DataTables/UsersDataTable.php

@@ -15,7 +15,8 @@ class UsersDataTable extends DataTable
      */
     public function dataTable(Builder $query): EloquentDataTable
     {
-        return datatables()->eloquent($query)->setRowId('id');
+        return (new EloquentDataTable($query))
+            ->setRowId('id');
     }
 
     public function query(User $user): Builder

tests/Providers/TestServiceProvider.php

@@ -6,7 +6,7 @@
 
 class TestServiceProvider extends ServiceProvider
 {
-    public function boot()
+    public function boot(): void
     {
         $this->loadViewsFrom(__DIR__.'/../views', 'tests');
     }

tests/TestCase.php

@@ -23,7 +23,7 @@ protected function setUp(): void
         $this->seedDatabase();
     }
 
-    protected function migrateDatabase()
+    protected function migrateDatabase(): void
     {
         /** @var \Illuminate\Database\Schema\Builder $schemaBuilder */
         $schemaBuilder = $this->app['db']->connection()->getSchemaBuilder();
@@ -62,7 +62,7 @@ protected function migrateDatabase()
         }
     }
 
-    protected function seedDatabase()
+    protected function seedDatabase(): void
     {
         $adminRole = Role::create(['role' => 'Administrator']);
         $userRole = Role::create(['role' => 'User']);
@@ -115,12 +115,12 @@ protected function getPackageProviders($app): array
         ];
     }
 
-    public function getAjax($uri, array $headers = []): TestResponse
+    public function getAjax(string $uri, array $headers = []): TestResponse
     {
         return $this->getJson($uri, array_merge(['X-Requested-With' => 'XMLHttpRequest'], $headers));
     }
 
-    public function postAjax($uri, array $headers = []): TestResponse
+    public function postAjax(string $uri, array $headers = []): TestResponse
     {
         return $this->postJson($uri, array_merge(['X-Requested-With' => 'XMLHttpRequest'], $headers));
     }